Replace `dataset` with `datasets` in simulation.py method

PolicyEngine / policyengine-core

Core microsimulation engine for PolicyEngine models. Forked from OpenFisca-Core.

https://policyengine.github.io/policyengine-core

GNU Affero General Public License v3.0

14 stars 20 forks source link

Replace `dataset` with `datasets` in simulation.py method #262

Closed MaxGhenis closed 2 months ago

MaxGhenis commented 2 months ago

I think this is causing errors like in this -us CI run:

https://github.com/PolicyEngine/policyengine-core/blob/c44ad2e94663e8783bae56d546cb385e7e254ce9/policyengine_core/simulations/simulation.py#L1422

due to

https://github.com/PolicyEngine/policyengine-core/blob/c44ad2e94663e8783bae56d546cb385e7e254ce9/policyengine_core/simulations/simulation.py#L63

anth-volk commented 2 months ago

I'm wondering if this is either a left hand not talking to right issue, or a much deeper issue. In this PR back in June or July, when handling of FLAT_FILE-type datasets was added, the simulations/simulation.py file already contained a reference within the build_from_dataset method to a self.dataset attribute that is clearly not enumerated within the beginning of the Simulation class.