search

PolicyEngine / policyengine-uk

The UK's only open-source static tax-benefit microsimulation model.
https://policyengine.github.io/policyengine-uk/
GNU Affero General Public License v3.0
29 stars 27 forks source link

Change label for `hours_worked` #451

Open MaxGhenis opened 2 years ago

MaxGhenis commented 2 years ago

To Hours worked per week so it's more descriptive in PolicyEngine:

image

https://github.com/PolicyEngine/openfisca-uk/blob/3a2c3516220c4ed171d60bbcaeeb4e440bb59272/openfisca_uk/variables/finance/income.py#L146

nikhilwoodruff commented 1 month ago

Look at that old interface!

MaxGhenis commented 1 month ago

Haha indeed. Should we change the definition_period to week?

https://github.com/PolicyEngine/policyengine-uk/blob/a8a2c1c7f867d990f7eb589f5436f68f45b25923/policyengine_uk/variables/household/income/income.py#L61-L66

anth-volk commented 1 month ago

Is there any potential that this would somehow be cast into a year-long value at some point, whether in calculation or in display on the front end?