search

PolicyEngine / policyengine-uk

The UK's only open-source static tax-benefit microsimulation model.
https://policyengine.github.io/policyengine-uk/
GNU Affero General Public License v3.0
23 stars 24 forks source link

Keep only adds or formula in household_benefits #808

Open MaxGhenis opened 5 months ago

MaxGhenis commented 5 months ago

As required by new policyengine-core, this has a formula and adds

https://github.com/PolicyEngine/policyengine-uk/blob/b9f48c16e4d0ef76f175314a3a19aac56fd9fbfb/policyengine_uk/variables/household/income/benefit.py#L52

anth-volk commented 5 months ago

Also

https://github.com/PolicyEngine/policyengine-uk/blob/b9f48c16e4d0ef76f175314a3a19aac56fd9fbfb/policyengine_uk/variables/gov/hmrc/tax.py#L14

MaxGhenis commented 5 months ago

Let's use adds and reforms as needed. Switching to a formula would result in it not decomposing in the app. See https://github.com/PolicyEngine/policyengine-us/issues/3851

MaxGhenis commented 4 months ago

See https://github.com/PolicyEngine/policyengine-us/pull/3972 for an example of a PR that applies reforms for these conditional lists