search

PolicyEngine / policyengine-uk

The UK's only open-source static tax-benefit microsimulation model.
https://policyengine.github.io/policyengine-uk/
GNU Affero General Public License v3.0
23 stars 24 forks source link

Care to learn #839

Closed Kittyaoooo closed 1 month ago

Kittyaoooo commented 3 months ago

add care to learn variables

Kittyaoooo commented 2 months ago

I've multiplied the data in the amount_per_child.yaml to get monthly amount, so the value returned should be monthly amount.

On Thu, Apr 25, 2024 at 10:10 AM Nikhil Woodruff @.***> wrote:

@.**** requested changes on this pull request.

In policyengine_uk/parameters/gov/dfe/care_to_learn.py https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PolicyEngine_policyengine-2Duk_pull_839-23discussion-5Fr1579548316&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=D4_TA5rySKIzQJTfuCZvuw&m=NU-naZdOMbfFKnxMKwTWxSkRDnya7lO1Hw4_C9t5zmPw95p8aG4N7K0LiLi-FE6L&s=SRAZJfgJGA77hH1hRegJeElieP40OpfKWDGogyPrzmo&e= :

     if live_in_london:
  • return amount_per_child.IN_LONDON # multiply to get monthly amount
  • return amount_per_child.IN_LONDON

I think this still returns the weekly amount, no?

— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PolicyEngine_policyengine-2Duk_pull_839-23pullrequestreview-2D2022633476&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=D4_TA5rySKIzQJTfuCZvuw&m=NU-naZdOMbfFKnxMKwTWxSkRDnya7lO1Hw4_C9t5zmPw95p8aG4N7K0LiLi-FE6L&s=OJokY1u7lXexg7BYfJ9UyiLcrqTMWnvYgo8h3LEoPGA&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AXIEG44ELR37J63NSWFVO33Y7EFFHAVCNFSM6AAAAABFALIPGKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRSGYZTGNBXGY&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=D4_TA5rySKIzQJTfuCZvuw&m=NU-naZdOMbfFKnxMKwTWxSkRDnya7lO1Hw4_C9t5zmPw95p8aG4N7K0LiLi-FE6L&s=o5sMTkdrTzvXDewOmPZ8aWZlJa2sZHDDVTBqG6C8B10&e= . You are receiving this because you authored the thread.Message ID: @.***>

nikhilwoodruff commented 2 months ago

@Kittyaoooo- sorry, we do need to multiply within the formula. This is because when we add references, they need to match the value in the parameter file, and if we've manually changed it to be monthly, it won't match.