Point `has_heating_cooling_expense` to `heating_expense` and `cooling_expense`

PolicyEngine / policyengine-us

The PolicyEngine US Python package contains a rules engine of the US tax-benefit system, and microdata generation for microsimulation analysis.

https://policyengine.org/us

GNU Affero General Public License v3.0

102 stars 175 forks source link

Point `has_heating_cooling_expense` to `heating_expense` and `cooling_expense` #3887

Open MaxGhenis opened 7 months ago

MaxGhenis commented 7 months ago

Drop heating_cooling_expense
Make heating_expense person-level
Drop heating_expense_person
Add cooling_expense

Shinuing commented 7 months ago

Drop heating_cooling_expense

Is the SPMUnit level heating_cooling_expense no longer needed? If so, the cliff_gap and marginal_tax_rate tests will fail.

MaxGhenis commented 7 months ago

After replacing the references to it with the list of heating_expense and cooling_expense?

Shinuing commented 7 months ago

After replacing the references to it with the list of heating_expense and cooling_expense?

Drop heating_cooling_expense but reference list of heating_expense and cooling_expense to has_heating_cooling_expense, the test failed with message below. However, there's no heating_cooling_expense in the cliff_gap.py and marginal_tax_rate, not sure what's this error coming from.

Keep heating_cooling_expense but reference with list of heating_expense and cooling_expense then the test passed