search

PolicyEngine / policyengine-us

The PolicyEngine US Python package contains a rules engine of the US tax-benefit system, and microdata generation for microsimulation analysis.
https://policyengine.org/us
GNU Affero General Public License v3.0
95 stars 167 forks source link

`test_repeal_head_of_household` failing after new version of core #4582

Open MaxGhenis opened 1 month ago

MaxGhenis commented 1 month ago

https://github.com/PolicyEngine/policyengine-us/blob/master/policyengine_us/tests/microsimulation/reforms/test_repeal_head_of_household.py

https://github.com/PolicyEngine/policyengine-us/actions/runs/9317273856/job/25653860997?pr=4576#step:5:1673

FAILED policyengine_us/tests/microsimulation/reforms/test_repeal_head_of_household.py::test_repeal_head_of_household - AssertionError: 
Not equal to tolerance rtol=1e-07, atol=0

x and y nan location mismatch:
 x: array([ 32459.   ,  44800.367,  19105.   , ..., 157421.36 ,  77087.65 ,
        93635.97 ], dtype=float32)
 y: array([ 32459.   ,  44800.367,  19105.   , ..., 157421.36 ,  77087.65 ,
        93635.97 ], dtype=float32)
====== 1 failed, 2567 passed, 13 skipped, 5 warnings in 131.26s (0:02:11) ======
make: *** [Makefile:10: test] Error 1
MaxGhenis commented 1 month ago

4588 pinned core, keeping this open to unpin

pmberg commented 1 week ago

Can confirm. I have this issue when I pin PolicyEngine Core 2.22.0 and 2.23.1 in installation, but not with 2.21.8.