search

PolicyEngine / policyengine-us

The PolicyEngine US Python package contains a rules engine of the US tax-benefit system, and microdata generation for microsimulation analysis.
https://policyengine.org/us
GNU Affero General Public License v3.0
95 stars 167 forks source link

Adjust the New Mexico refundable credits parameter files #4620

Closed PavelMakarchuk closed 3 weeks ago

PavelMakarchuk commented 3 weeks ago

Fixes #4619

MaxGhenis commented 3 weeks ago

should we be just deleting those tests rather than adjusting them?

PavelMakarchuk commented 3 weeks ago

should we be just deleting those tests rather than adjusting them?

Generally we should definitely not just remove tests but I think here it is the best way to avoid misleading assumptions about the code structure.

The tests were checking the structure of zeroing out parameters for the years that the program does not exist. Since this is not practice anymore those tests are obsolete - they would check exactly the same situation for e.g. 2021 and 2022 while there is nothing in the variables and parameters that would lead to the necessity of such tests.