search

PolicyEngine / policyengine-us

The PolicyEngine US Python package contains a rules engine of the US tax-benefit system, and microdata generation for microsimulation analysis.
https://policyengine.org/us
GNU Affero General Public License v3.0
103 stars 176 forks source link

Refactor CTC related variables #5151

Closed PavelMakarchuk closed 1 month ago

PavelMakarchuk commented 1 month ago

Fixes #5150 and fixes #4800 Separated the CTC phase-in for clarity Adjusted the CTC value variable to reflect the total possible CTC value which does not take other non refundable credits into account

PavelMakarchuk commented 1 month ago

Could you please add a unit test for refundable_ctc while you're here?

Do you feel confident enough in our integration tests that this isn't changing any end CTC results?

I didn't really do any serioues structural changes - separated out the phase-in which is tested in multiple integration and unit tests and the ctc_value file does not affect any output directly - given that I am confident