search

PolicyEngine / policyengine-us

The PolicyEngine US Python package contains a rules engine of the US tax-benefit system, and microdata generation for microsimulation analysis.
https://policyengine.org/us
GNU Affero General Public License v3.0
103 stars 176 forks source link

`gov.irs.deductions.itemized.salt_and_real_estate` unit is `null`/`None` #5208

Open anth-volk opened 3 weeks ago

anth-volk commented 3 weeks ago

I hope this isn't a trait of scale params, but for the param in the title, the unit in the metadata is null/None, making it difficult to properly parse when attempting to do some layout work on the front end. Would be great to modify -core to force parameters to have all of these properties and raise a build error if they don't.

MaxGhenis commented 3 weeks ago

It does have the unit:

https://github.com/PolicyEngine/policyengine-us/blob/0051378a5e815ee5559d358fba803a89ef6b717e/policyengine_us/parameters/gov/irs/deductions/itemized/salt_and_real_estate/cap.yaml#L3

Might need propagate_metadata_to_children: true as I see it doesn't have $ in the web app.