search

PolicyEngine / policyengine

Source code for PolicyEngine
https://policyengine.org
GNU Affero General Public License v3.0
12 stars 4 forks source link

[Inconsistent] Reform shows no impact when opening by URL after previously creating it #879

Closed MaxGhenis closed 2 years ago

MaxGhenis commented 2 years ago

I haven't been able to reproduce this since it happened, but I just opened this reform by URL after previously creating it: https://policyengine.org/us/population-impact?wa_wftc_max_amount_0_rate=600&wa_wftc_max_amount_1_rate=1200&wa_wftc_max_amount_2_rate=1800&wa_wftc_max_amount_3_rate=2400&baseline_state_specific=WA

It should say a $224m net cost, but when I opened it, it said $0, and the changes that should have only been in the reform were also in the baseline.

MaxGhenis commented 2 years ago

This happened again with this Maryland reform.

The first time I clicked on it it showed zero. Then I clicked it again and it recomputed to arrive at the correct non-null results.

Also, clicking the link in my initial comment of this issue produced a zero value.

@nikhilwoodruff any chance the refactor fixes this? If not I think we should make it a high priority; I can't share state-specific links with confidence e.g. for blog posts announcing state launches.

nikhilwoodruff commented 2 years ago

Fixed by #900 (afaict after trying that link a few times).