search

PolicyEngine / policyengine

Source code for PolicyEngine
https://policyengine.org
GNU Affero General Public License v3.0
12 stars 4 forks source link

Several reforms are producing order-of-magnitude-off errors #903

Closed MaxGhenis closed 2 years ago

MaxGhenis commented 2 years ago

We have a major bug. Could be something with the baseline? We should probably shut off the app until we pin it down.

An empty reform is showing $10tn in impact: https://policyengine.org/us/population-impact

A minor Maryland reform is showing billions in impact (should be tens or hundreds of millions): https://policyengine.org/us/population-impact?md_cdcc_percent=0&md_non_single_childless_non_refundable_eitc_match=0&md_eitc_refundable_match=0&baseline_state_specific=MD

nikhilwoodruff commented 2 years ago

Just checked @MaxGhenis - both of these examples are now corrected for me ($0, and $228m).

MaxGhenis commented 2 years ago

This (or something like it) has resurfaced, e.g. this reform that replaces SNAP/TANF/SSI with a $100/mo adult UBI has a top-level budgetary impact way too high and misaligned with the budgetary impact chart. That chart also shows tax savings where none should exist.

image
MaxGhenis commented 2 years ago

This link in https://github.com/PolicyEngine/policyengine/issues/903#issuecomment-1214285562 works correctly after making an unrelated update to PolicyEngine. But I'm leaving it open until we diagnose and fix it.

MaxGhenis commented 2 years ago

it's back - this occurred around 12:45pm PT

image