search

PolicyStat / ckeditor-plugin-structured-headings

MIT License
0 stars 1 forks source link

Dropdown change events may not be working properly #50

Closed caffodian closed 7 years ago

caffodian commented 7 years ago

We have an autosave plugin that hooks into CKEditor, however, it doesn't appear to detect dirtiness when headings are applied or unapplied

caffodian commented 7 years ago

Possibly need to be firing the http://docs.ckeditor.com/#!/api/CKEDITOR.editor-event-updateSnapshot at the end of our dropdown ops

caffodian commented 7 years ago

Better yet, just lockSnapshot & unlockSnapshot everywhere

caffodian commented 7 years ago

The "classic" style combo fired snapshot simply saves a snapshot before and after you apply a style.

Our replacement for it doesn't do any such thing, which explains the random undo behaviour (if you accidentally do something else, it adds to undo)

caffodian commented 7 years ago

The setting numbering style is a bit worse, something in between has a side effect of creating a snapshot, so we do need to actually lock it

caffodian commented 7 years ago

This is surprisingly super annoying, managing snapshot side effects is horrible.