search

PolicyStat / ckeditor-plugin-structured-headings

MIT License
0 stars 1 forks source link

Fix up the dropdown displayed value #62

Closed caffodian closed 7 years ago

caffodian commented 7 years ago

We have a bunch of magic strings and direct calling of setValue, and sometimes the text doesn't actually match the selected option anymore. :/

(mainly saw this with clear)

caffodian commented 7 years ago

This will be way easier after refactoring the dropdown. It currently does too many things based on selection and there's not a clear path of "look at the value from the dropdown" -> "do something" -> "update the dropdown with the correct value", many of the unexpected display values are due to mishaps along the way

caffodian commented 7 years ago

This is made more consistent after the change to store the current scheme for a doc.