Parallel - Githubissues

PolicyStat / ckeditor-spell-check-plugin-js-dev-edge

User interface enhancements and beta features for http://ckeditor-spellcheck.nanospell.com . This repo is for nanospell developers and trusted partners to modify and fork plugin.js

Other

0 stars 0 forks source link

Parallel #11

Closed sbaughman closed 8 years ago

sbaughman commented 8 years ago

Changes initial document spellcheck to be split into block-level elements so they can occur in parallel. Also fixes a bug that caused changes to text inside a spellcheck span to trigger a whole-document spellcheck

caffodian commented 8 years ago

Looks good so far.

One idea for how to manual test this:

copy this new version into site_media/lib/ckeditor-common/nanospell on the PolicyStat dev box
override an existing policy. Replace it with a LOT of generated lorem ipsum text (you may need to runserver with the following env due to a unicode issue w/ django debug toolbar PSTAT_HIDE_DEBUG_TOOLBAR=1 ./pstat/manage.py runserver 0.0.0.0:8000
save it
open the policy again and see if it's more responsive on the initial load.

caffodian commented 8 years ago

I'd also like to work through that nested list case again. Another similar case would be for paragraph tags inside table cells, which ckeditor also gets weird with, as far as getNextParagraph is concerned.

caffodian commented 8 years ago

I really appreciate that you looked at it with fresh eyes and were able to make some clarity improvements as well. I had been deep into the rewrite about a month ago and lost a lot of that context.

caffodian commented 8 years ago

This is definitely a later thing, unless the cause is really obvious.

You can type (including inserting new elements) while spellcheck is running.

however, spellcheck does not trigger. Had to type more into the block after it was done to trigger something.

caffodian commented 8 years ago

An actual bug - things like the source dialog don't work while spellcheck is running. This is probably due to some weird race condition but eventually resolves itself when all the spans have been marked.

Might have something to do with the filters, which remove spans before sending it off to the source dialog