Prevent concurrent spellcheck runs and list with text + table madness

PolicyStat / ckeditor-spell-check-plugin-js-dev-edge

User interface enhancements and beta features for http://ckeditor-spellcheck.nanospell.com . This repo is for nanospell developers and trusted partners to modify and fork plugin.js

Other

0 stars 0 forks source link

Prevent concurrent spellcheck runs and list with text + table madness #3

Closed caffodian closed 8 years ago

caffodian commented 8 years ago

This actually prevents two issues:

concurrent spellcheck runs (hard to test, but long running spellcheck causes multiple spellchecks to run at the same time and destroy each other)
list item with text followed by a table causes walker to misbehave and include the table cells when walking the list item.

winhamwr commented 8 years ago

The error handling for the AJAX request is going to need some work. Right now, if any request fails (timeout, intermittent 500, whatever), spellcheck will be broken on that page from then on, since it won't get to the render() method and our _isBusy check will always say that we're in the middle of a check.

Doing that in a separate PR would make sense to me.