Prevent nested spans and problems where a previously typoed part of a word stays marked forever

PolicyStat / ckeditor-spell-check-plugin-js-dev-edge

User interface enhancements and beta features for http://ckeditor-spellcheck.nanospell.com . This repo is for nanospell developers and trusted partners to modify and fork plugin.js

Other

0 stars 0 forks source link

Prevent nested spans and problems where a previously typoed part of a word stays marked forever #32

Closed caffodian closed 8 years ago

caffodian commented 8 years ago

Fix for #29 by:

not marking the current word (which is actually quite crazy, as depending on the html, the selection can be in various places)
correcting some cases of joining typos together (backspace, but not delete)
if we try to mark a range that already has marks within it, clear them out

caffodian commented 8 years ago

Going to play with this a bit before review. This stuff is hard to only test with code and i'm not super confident I didn't accidentally break something. :/

caffodian commented 8 years ago

Fun fact, i fixed Deleting a non-typo into a typo, but not backspacing. (because of funny behaviour around which nodes it thinks it is touching.) Going to punt on this issue though.

bocribbz commented 8 years ago

looks good to me.