caffodian
commented
8 years ago Option 2 won't always work if the selection is not the first word, since marking words will invalidate the selection (if it's not bookmarked)
Option 1 definitely doesn't work, either.
Something that might make more sense with some thought:
- split the word walker into two.
- it now uses two dom walkers instead of 1.
- first half: goes from start of range until it hits a bookmark. Throw out the last word you find, which should be a partial
- second half: go from where the first half ended, to the end of the range. Throw out the first word that happens before a word separator, which should be a partial word
Creating a bookmark in IE11 modifies the selection ranges.
In the
rendermethod, before going in and marking spans, we create a bookmark at the current selection. This causes the really simple "ignore the current selection" code in the Wordwalker to fail.There are a few ways out of this:
1) Really optimistically: because we no longer care about marking the current word, we no longer need to set bookmarks in order for the cursor to not move (very unlikely this actually works, but worth trying) 2) get the selection before creating the bookmark, since we only care about it for the purposes of marking the text node that we don't care about. this may still not work since the bookmark might do something bad.
3) take another pass at the "find the currently selected word" code. It should also ignore empty trailing children instead of just always looking at the last child. (I am most sure that this will work, though it feels the most hacky)