search

PolicyStat / ckeditor-spell-check-plugin-js-dev-edge

User interface enhancements and beta features for http://ckeditor-spellcheck.nanospell.com . This repo is for nanospell developers and trusted partners to modify and fork plugin.js
Other
0 stars 0 forks source link

Fix #38 - don't create bookmarks out of the current selection's block #42

Closed caffodian closed 7 years ago

caffodian commented 8 years ago

Make needsBookmarkCreated actually do something, remove bookmark creation elsewhere.

caffodian commented 8 years ago

in the next PR, needsBookmarkCreated needs to be calculated within render (because render is now wrapped inside a setTimeout, meaning the selection can change between the time it is scheduled & actually ran )

caffodian commented 8 years ago

The performance benefit of this on its own is only about 20-40ms per spellcheck, so it's unlikely to be worth rolling out on its own. There are also parts of it that are going to be re-done in the course of making things more async.