search

PolicyStat / ckeditor-spell-check-plugin-js-dev-edge

User interface enhancements and beta features for http://ckeditor-spellcheck.nanospell.com . This repo is for nanospell developers and trusted partners to modify and fork plugin.js
Other
0 stars 0 forks source link

Set up Travis + fix some flaky tests #9

Closed caffodian closed 8 years ago

caffodian commented 8 years ago

Set up Travis (hopefully it works without me just merging all the way into master. but oh well, if it does.)

Fix some flaky tests as well, perhaps only in a brutal way, though.

caffodian commented 8 years ago

Doh. Yea, it doesn't run. So the followup is to replace master with what is in pstat_rewrite (we will need to do a giant upstream merge once the obvious broken things are no longer broken.)

caffodian commented 8 years ago

Oh. I was an idiot and didn't push before leaving the house earlier. Ha.

caffodian commented 8 years ago

Right. one other flaky test I didn't look into..

caffodian commented 8 years ago

It wasn't flaky. I just didn't know how to skip it, and wasn't running CI at the time.

winhamwr commented 8 years ago

So the followup is to replace master with what is in pstat_rewrite

I'm pretty sure there's a Travis option to run tests against all PRs, which would service. Maybe there's also an option to set a branch other than master as the branch to run?

caffodian commented 8 years ago

I'm pretty sure there's a Travis option to run tests against all PRs, which would service. Maybe there's also an option to set a branch other than master as the branch to run?

See my update, I was just being silly and though I pushed before I came back to check the results. There is an option to only test if travis.yml is present, which is enabled.

winhamwr commented 8 years ago

Maybe "later" is the right time to do some of the refactoring I suggested. Looks good overall.