PolicyStat / hubot

2 stars 0 forks source link

When updating the branch status, update the appropriate commit instead of always updating the head #6

Closed kylegibson closed 11 years ago

kylegibson commented 11 years ago

Currently whenever the branch status is updated to indicate whether tests are passing or failing, we always mark the head commit. This is bad, because it can result in code being merged in and deployed that hasn't been tested.

When hubot receives instructions to run the tests, save the commit. As test results are received, retrieve the saved commit and update it.

Also:

winhamwr commented 11 years ago

Updated the spec to cover the rest of the stuff I did.

kylegibson commented 11 years ago

We should consider making a flow diagram to assist in grokking how this works.

winhamwr commented 11 years ago

Any other review stuff I can fix in the master branch. We were already using this live, anyway :)

Also, I can't read the trello card and thought you had already moved this before I clicked merge. derp

kylegibson commented 11 years ago

Nice