search

PolicyStat / terrarium

Package and ship relocatable python virtualenvs, like a boss.
https://terrarium.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
171 stars 14 forks source link

Add support for virtualenv 12.0 #51

Closed tinycogio closed 7 years ago

tinycogio commented 9 years ago

Looks like virtualenv 12.0 was released today, and they removed all the older versions. The dependencies for virtualenv in setup.py needs to be updated accordingly.

kylegibson commented 9 years ago

Good call. @winhamwr Do you think we should cut a 1.0.0 before, or after, updating support for recent virtualenv/pip releases? We're fairly far behind.

winhamwr commented 9 years ago

I would say we update support and then cut a 1.0. Seems like an excellent impetus to call it 1.0

winhamwr commented 9 years ago

Hi Giovanni,

they removed all the older versions

I don't think I follow what that means. Our travis build runs against each of the versions of virtualenv that we support (1.7.X, 1.8.X and 1.9.X), and those tests are passing. It appears that prior versions are still available via pypi.

We would definitely like to support 1.10, 1.11 and 12.x. They have some backwords incompatible changes, though, so someone will need to put in the effort for support. I haven't yet had a need/desire to upgrade to a newer version of virtualenv, so it hasn't made sense for me, yet. Pull requests are definitely welcome :)

Thanks -Wes

tinycogio commented 9 years ago

Hi,

At the time, our servers could not install virtualenv 1.9.1 (as required by terrarium's setup.py) as it appeared to be missing from pypi. I thought they removed all older versions by using the yolk command to list out all version of the package, but it seems that yolk only shows the current version (or I'm doing something wrong).

I ended up manually updating the requirements.txt file in terrarium to 'virtualenv>=12.0,<13.0' which seems to be working fine for us.

Looks like I am also able to install virtualenv 1.9.1 now so looks like the problem was temporary which is good to know since we also don't require the latest version of virtualenv.

Thanks for getting back to me!

kylegibson commented 7 years ago

Terrarium has been updated to explicitly support and test against 15.0.x and 15.1.x in additional to the older versions. Eventually we'll drop explicit support for the older versions.