Polidea / RxBluetoothKit

iOS & OSX Bluetooth library for RxSwift
Apache License 2.0
1.41k stars 366 forks source link

Add Swift Version to Podspec #325

Closed jasdeepsaini closed 5 years ago

jasdeepsaini commented 5 years ago

Added the swift version parameter to the podspec. This will keep the pod from breaking when new versions of Swift are released.

Not sure if this is something you want in the codebase, but it avoids having to add code like the following to everyone's Podfile.

post_install do |installer|
    installer.pods_project.targets.each do |target|
        if target.name == '<insert target name of your pod here>'
            target.build_configurations.each do |config|
                config.build_settings['SWIFT_VERSION'] = '3.0'
            end
        end
    end
end
CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jasdeep Saini seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

minixT commented 5 years ago

@jasdeepsaini thank you for your PR. We introduced this after your suggestion in version 5.2.0. I'm closing this PR.