Added explicit architectures for each framework target

Polidea / RxBluetoothKit

iOS & OSX Bluetooth library for RxSwift

Apache License 2.0

1.41k stars 366 forks source link

Added explicit architectures for each framework target #333

Closed jbfitb closed 5 years ago

jbfitb commented 5 years ago

Issue

Xcode 10's new build system matches framework based on sdk and target architecture and name
Before this change: macOS and watchOS frameworks were sometimes being build whenever we'd target iOS simulator x86_64 in our main app

Change

This pull request sets explicit architectures for each build target and sdk
I've verified that this stops RxBluetoothKit from building macOS and watchOS targets when included in an iOS app.

CLAassistant commented 5 years ago

All committers have signed the CLA.

c0diq commented 5 years ago

Is there a reason why RxBluetoothkit prefers a separate target per platform instead of a single target that supports all platforms (like RxSwift does for example)?

minixT commented 5 years ago

Hi @jbfitbit. Thank you for you pull request.

Can you describe what are the benefits of your solution?

jbfitb commented 5 years ago

We were able to fix this issue by specifying AVAILABLE_PLATFORMS = iphoneos iphonesimulator in our root xcconfig file. Seems like without this, xcodebuild was building for all platforms.