search

Polidea / RxBluetoothKit

iOS & OSX Bluetooth library for RxSwift
Apache License 2.0
1.41k stars 366 forks source link

Added support for observing ancsAuthorized property on peripheral. #370

Closed radumvlad closed 4 years ago

radumvlad commented 4 years ago

Added support for ancsAuthorized property that was introduced in iOS 13: https://developer.apple.com/documentation/corebluetooth/cbperipheral/3180040-ancsauthorized

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

radumvlad commented 4 years ago

CI will continue failing since it is using XCode 10.2. Not sure if there's anything I can do for this.

minixT commented 4 years ago

CI will continue failing since it is using XCode 10.2. Not sure if there's anything I can do for this.

Please update .travis.yml and use xcode11.6 osx_image. This should fix problems with failing build.

minixT commented 4 years ago

I'm already working on updating our CI configuration. Please wait until I finish this. After that I'll merge your PR.

radumvlad commented 4 years ago

Unfortunately, generate-mocks.sh only uses iPhone sdk, but not also macOS sdk. I tried changing the script, but just changing the sdk_path doesn't seem to do it, so it beats me. For now I manually added an #if !macOS so the tests run accordingly.

minixT commented 4 years ago

Unfortunately, generate-mocks.sh only uses iPhone sdk, but not also macOS sdk. I tried changing the script, but just changing the sdk_path doesn't seem to do it, so it beats me. For now I manually added an #if !macOS so the tests run accordingly.

I'm working on changes in the generate-mocks.sh script to fix this problem I hope I will manage to complete this soon.

radumvlad commented 4 years ago

Thank you @minixT , I will leave this to you.

minixT commented 4 years ago

@radumvlad I've updated generate-mocks.sh script. Please merge current master branch and regenerate mocks. It should resolve your problems.