🗑️ Scrap Async Instantiation

Polimec / polimec-node

Decentralized community-driven funding protocol for Web3

https://www.polimec.org/

GNU General Public License v3.0

14 stars 6 forks source link

🗑️ Scrap Async Instantiation #310

Closed JuaniRios closed 5 months ago

JuaniRios commented 5 months ago

What?

Remove async instantiation

Why?

Tried making genesis parallel instantiation work, but after the SDK update it seems it's no longer possible due to features like "std" not being passed when calling the runtime for the genesis raw spec creation.
It is used only in a few tests, and so it's better to delete it all to avoid maintaining it.

How?

Delete the async file
Modify tests that used it
Remove the populated chain spec

JuaniRios commented 5 months ago

#310 👈
#308 : 2 other dependent PRs (#311 , #312 )
#307
#306
#304
#303 : 1 other dependent PR (#315 )
#302
#301
#299 : 1 other dependent PR (#300 )
#296
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite

JuaniRios commented 5 months ago

Love every piece of code simplification! I was wondering about the whole RefCell setup. I can vaguely remember that it was needed for the Async feature with different execution environments? I was wondering if we could change this RefCell implementation now, as we do not require the std execution environment anymore? I might be completely mistaken, but just a general question.

RefCell is there for tests, since we need to setup the mock externalities manually. We use "std" because is needed in both tests and benchmark tests, but cannot be included in the wasm runtime