search

Polimec / polimec-node

Decentralized community-driven funding protocol for Web3
https://www.polimec.org/
GNU General Public License v3.0
12 stars 4 forks source link

👨🏻‍💻 Reorg extrinsics #345

Closed JuaniRios closed 2 months ago

JuaniRios commented 3 months ago

What?

Change the order, naming, and indexing of some extrinsics

Why?

Easier readability, and less guessing what the next index will be for new extrinsics

JuaniRios commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

graphite-app[bot] commented 3 months ago

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (07/02/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

lrazovic commented 3 months ago

However, we might change some protocol flow as well (merge auction rounds, merge community + remainder round and maybe remove decision logic) so we might have to do the reindexing all over again.

In order to minimize the number of times we do a re-index, isn't it better to do it once the protocol simplification has been done?

vstam1 commented 3 months ago

Yeah think so as well!

JuaniRios commented 3 months ago

However, we might change some protocol flow as well (merge auction rounds, merge community + remainder round and maybe remove decision logic) so we might have to do the reindexing all over again.

In order to minimize the number of times we do a re-index, isn't it better to do it once the protocol simplification has been done?

Right now there is no reason not to reindex. But that might change in the future. So I would rather reindex now since we know there are no side effects.

We already have the indexes all over the place

JuaniRios commented 2 months ago

Merge activity