Vstam1/simplifications

[vstam1]

The following simplifications are proposed:

• [x] Remove Candlestick Auction
• [x] Merge Community Remainder Round
• [x] Remove Project decision
• [x] Remove automatic transition for transition
  • [x] Remove on_initialize logic
  • [x] Adjust all transition inner functions to handle transition
  • [x] Update all root functions -> normal functions, that anyone can call to transition the project
• [x] Rewards payout for evaluators based on total value evaluated, so removal of evaluators iterator
• [x] Remove Y variable from rewards payout

Todo:

• [x] Implement all simplifications
• [x] Fix all the TODO Simplification comments
• [x] Remove random end block
• [x] Update tests based on simplifications
• [ ] Update benchmarks + used weights + weight returns of functions
• [x] General cleanup
• [ ] Test with chopsticks if everything functions correctly (especially round transitions)
• [ ] Update Felix on breaking changes, so we can prepare front-end
• [ ] Create offchain worker script that queries project states and round durations and trigger transition function once round if over.
• [ ] Test on Rolimec

Important things to test:

• [x] Does the settlement of failed bids work properly using the settle_failed_bids function. See candlestick commit
• [x] Does refunding of either Partial bid or Bid with original_price > wap work correctly using settle_succesful bid. See candlestick commit
• [x] Double check new wap calculation based on bucket. Already one test added.
• [x] If all round transitions are not set up correctly, with the correct checks. Check if not possible to transition early, or call it again after round already transitioned with the new round_duration structure and generalized transition function.
• [x] Test the merge of community + remainder round. See following lines for important changes:
  • [x] Buy last CT in com/rem round if ticket size < min_ticket_size. here
  • [x] Active bidder can participate after status::CommunityRound(BLOCK_NUMBER). See round transition and check
• [x] The full new funding_end structure where project decision has been removed.

[JuaniRios]

• #364 : 2 dependent PRs (#366 , #370 )
• #363
• #362
• #361
• #358 👈
• #354
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vstam1 and the rest of your teammates on Graphite

[JuaniRios]

Merge activity

• Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
• Aug 23, 5:56 AM EDT: @JuaniRios merged this pull request with Graphite.