🔧 Fix migration test - Githubissues

Polimec / polimec-node

Decentralized community-driven funding protocol for Web3

https://www.polimec.org/

GNU General Public License v3.0

12 stars 4 forks source link

🔧 Fix migration test #360

Closed JuaniRios closed 2 months ago

JuaniRios commented 2 months ago

What?

Fix our pallet migration integration test

Why?

We added a real benchmarked weight to the confirm_pallet_migrations extrinsic, but forgot to reflect that change when setting the max weight for the ReportTransactStatus message appended at the end of a migration.

How?

The xcm logs showed that the message was overweight:

 events::Polimec: RuntimeEvent::PolkadotXcm(Event::NotifyOverweight { query_id: 2, pallet_index: 80, call_index: 30, actual_weight: Weight { ref_time: 573050100, proof_size: 33831 }, max_budgeted_weight: Weight { ref_time: 700000000, proof_size: 10000 } })

As you can see the actual weight was:

Weight { ref_time: 573050100, proof_size: 33831 }

And the max weight we set was

Weight { ref_time: 700000000, proof_size: 10000 }

Therefore we now increase the max weight to 1_000_000_000 and 50_000

Testing?

run full_pallet_migration_test

JuaniRios commented 2 months ago

#360 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite