'obs.mount.goToTarget2' should replace everywhere `obs.mount.goToTarget`

EastEriq commented 2 months ago

and be renamed goToTarget, phasing out the former one.

Currently goToTarget is still used in takeTwilightFlats, and I'm cautious about replacing it, because the behavior of the two functions is not the same in the absence of a pointing model.

Other obsolete functions using it, which shouldn't worry us:

testing/randomObservationTest.m
+obs/@unitCS/operateUnit.m
+obs/@unitCS/pointAndClickMove.m
+obs/+util/+observation/obsByPriority.m
+obs/+util/+observation/observe.m
crap/loopOverTargets.m
crap/loopOverTargets_old.m

EastEriq commented 1 month ago

moved the old goToTarget to @mount/obsolete/ and renamed autoritatively gotoTarget2 -> goToTarget everywhere. Happens what it happens.

EastEriq commented 1 month ago

I provisionally close this for the milestone, let's return on it if e.g. pointAndClickMove is not happy with it -- which is out of scope for the milestone. Old stuff has high chances to be unwieldy with gledmagicwater, anyway.

PolishookDavid / LAST_OCS

'obs.mount.goToTarget2' should replace everywhere `obs.mount.goToTarget` #20