search

PoliticalFraming / politicalframing

http://www.politicalframing.com
9 stars 1 forks source link

Error in HTML View for Filters that result in no speeches #51

Open AlJohri opened 10 years ago

AlJohri commented 10 years ago

If any filters cause there to be no speeches found, the "select filters and click browse" message shows up again.

We used to do ng-show="speeches" on the filters so that you are forced to put in a phrase first. However, if your filters cause there to be no speeches, speeches becomes an empty list [] and thus the filters will disappear. You can't change the filters anymore...

AlJohri commented 10 years ago

Temporary fix has been done that just removes ng-show attributes on the other filters. Will look into this more later.

https://github.com/PoliticalFraming/politicalframing/commit/4354ec918d965fd71849da805a8fb92f5b9356c3#diff-9341fe9ea911fc7013141e97221d6722L32