PolkaGate / extension

The official extension of PolkaGate. A user-friendly wallet for seamless browser-based interaction with Polkadot/Substrate-based blockchains.
https://polkagate.xyz
Apache License 2.0
2 stars 5 forks source link

Fix import proxied: import proxied does not work if you switch chain or address after first try #1353

Closed Nick-1979 closed 3 months ago

Nick-1979 commented 3 months ago

closes #1352

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The updates address the issue where importing proxied accounts fails after switching chains or addresses. Changes include adding a new case in Bread.tsx, refining logic in useProxiedAccounts.ts to handle api and formatted parameters, adjusting layout and imports in importProxiedFullScreen/index.tsx, and adding a genesisHash field to the ProxiedAccounts type.

Changes

Files/Paths Change Summary
.../fullscreen/partials/Bread.tsx Added a new case 'import' to the switch statement for the path variable.
.../hooks/useProxiedAccounts.ts Added ApiPromise import, modified getProxiedAccounts to accept api and formatted parameters, updated logic, dependencies in useEffect, and refined return statement using useMemo.
.../popup/import/importProxied/ProxiedTable.tsx Adjusted allSelected variable assignment by removing unnecessary whitespace.
.../popup/import/importProxiedFullScreen/index.tsx Modified imports and component structure, added Bread and Title components, dynamic table height calculation.
.../util/types.ts Added genesisHash field to the ProxiedAccounts type.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant UI
    participant Hooks
    participant API

    User->>UI: Navigate to import proxied accounts
    UI->>Hooks: Fetch proxied accounts
    Hooks->>API: Get proxied accounts with api and formatted parameters
    API-->>Hooks: Return proxied accounts with genesisHash
    Hooks-->>UI: Provide proxied accounts data
    UI-->>User: Display proxied accounts

    User->>UI: Switch chain or address
    UI->>Hooks: Fetch updated proxied accounts
    Hooks->>API: Get updated proxied accounts with new api and formatted parameters
    API-->>Hooks: Return updated proxied accounts with genesisHash
    Hooks-->>UI: Provide updated proxied accounts data
    UI-->>User: Display updated proxied accounts

Assessment against linked issues

Objective Addressed Explanation
Import proxied does not work if you switch chain or address after first try (#1352)

Poem

In the code where proxies dwell,
A bug once cast its tricky spell.
We switched the chains, the paths anew,
And now the proxies follow through.
With hashes, heights, and logic keen,
Our import flows like a dream serene.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.