Reauthorization [TEST] - Githubissues

AMIRKHANEF commented 2 months ago

Works Done

[x] Add reauthorization feature when new account added/imported.
[x] Add addedTime to the keyring of the created, imported or added accounts.
[x] Add addedTime to the type.
[x] Update Request.tsx.
[x] Update ImportFromJSONFile.tsx in order to add addedTime to the imported accounts from JSON file.

close: #1492

Summary by CodeRabbit

New Features
- Enhanced account management with timestamp tracking for account creation and restoration.
- Introduced optional parameters for reauthorization handling in authorization methods.
- Added functionality to dynamically retrieve authorization lists in the Request component.
- Improved metadata handling for accounts in the RestoreJson component.
- Updated interfaces to include properties for tracking authorization and account addition times.
- Added a new translation entry for the term "Ignore" to improve localization.
Bug Fixes
- Ensured consistent handling of authorization times across existing entries.
Documentation
- Updated type definitions to include new properties related to time tracking for authorizations and account management.
Style
- Minor formatting adjustments made to improve code readability without altering functionality.

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve enhancing account management and authorization processes within the extension. Key modifications include the addition of timestamps for account creation and authorization, updating methods to accommodate these timestamps, and refining logic for handling authorizations and account listings. The introduction of new properties and methods allows for better tracking of account metadata, improving overall functionality.

Changes

Files	Change Summary
`packages/extension-base/src/background/handlers/Extension.ts`	Added `applyAddedTime` method for timestamp tracking during account creation and restoration.
`packages/extension-base/src/background/handlers/State.ts`	Updated `AuthUrlInfo` to include `authorizedTime` for tracking authorization timestamps.
`packages/extension-base/src/background/handlers/Tabs.ts`	Modified `transformAccounts` to include `addedTime` and updated `authorize` and `accountsListAuthorized` methods.
`packages/extension-base/src/background/types.ts`	Updated interfaces to include `authorizedTime` and `addedTime`, added new `ApplyAddedTime` interface.
`packages/extension-inject/src/types.ts`	Added optional `addedTime` property to `InjectedAccount` interface.
`packages/extension-polkagate/src/popup/authorize/Request.tsx`	Integrated dynamic fetching of authorization lists and updated state management for selected accounts.
`packages/extension-polkagate/src/popup/import/restoreJSONFullScreen/index.tsx`	Added metadata handling for account timestamps in `RestoreJson` function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Extension
    participant State
    participant Tabs

    User->>Extension: Create/Restore Account
    Extension->>keyring: Create/Restore Account
    keyring-->>Extension: Return Pair
    Extension->>Extension: applyAddedTime(pair)
    Extension->>State: Update authorizedTime
    Extension->>Tabs: Update account list
    Tabs-->>User: Show updated accounts

Assessment against linked issues

Objective	Addressed	Explanation
if a new account is added we need a new authorization popup (#1492)	✅

🐇 Hop, hop, hooray, with each new account's birth,
Timestamps now track their worth,
In the world of code, we play,
Authorizations bright and gay,
With every change, we leap and cheer,
For better management is finally here! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

Early access features: disabled

We are currently testing the following features in early access: - **Anthropic `claude-3-5-sonnet` for code reviews**: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues on the [discussion post](https://discordapp.com/channels/1134356397673414807/1279579842131787838).

Nick-1979 commented 2 months ago

The reauthorization window does not appear for already authorized URLs when new accounts are added.
- It's better to use 'Ignore' instead of 'Reject' as the button label.

AMIRKHANEF commented 2 months ago

The reauthorization window does not appear for already authorized URLs when new accounts are added.

It's better to use 'Ignore' instead of 'Reject' as the button label.

All fixed