PolkaGate / extension

The official extension of PolkaGate. A user-friendly wallet for seamless browser-based interaction with Polkadot/Substrate-based blockchains.
https://polkagate.xyz
Apache License 2.0
2 stars 5 forks source link

feat: use Slider for Conviction settings #1629

Closed Nick-1979 closed 1 week ago

Nick-1979 commented 1 week ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant updates to the Convictions component and related files, enhancing functionality and styling. Key changes include the addition of a Slider component and new imports from @mui/material, a revised useConvictionOptions hook, and updates to the Cast component to improve voting logic. Theme files for both light and dark modes have been modified to include new color properties. Additionally, new components like DraggableModalWithTitle and ModalTitleWithDrag have been introduced, collectively aiming to streamline user interactions and improve the maintainability of the codebase.

Changes

File Path Change Summary
packages/extension-polkagate/src/components/Convictions.tsx Added imports for Slider, Typography, and useTheme. Updated function signature to include DEFAULT_CONVICTION. Modified onChangeConviction logic and introduced new state variables for max and min values. Replaced Select with Slider and updated return structure.
packages/extension-polkagate/src/fullscreen/governance/post/castVote/Cast.tsx Removed import for Vote type. Imported DEFAULT_CONVICTION from Convictions. Updated props and internal logic for previousVote. Introduced useInfo hook for state management and refined rendering logic for voting buttons.
packages/extension-polkagate/src/hooks/useConvictionOptions.ts Changed return type to DropdownOption[]. Removed t: TFunction parameter. Simplified state management and adjusted property access for conviction data.
packages/extension-polkagate/src/themes/dark.ts Expanded Palette and PaletteOptions interfaces with new properties. Updated success property in darkTheme to include a light variant.
packages/extension-polkagate/src/themes/light.ts Similar updates as in dark.ts, adding new properties to Palette and PaletteOptions, and updating success property in lightTheme to include a light variant.
packages/extension-polkagate/src/fullscreen/governance/components/DraggableModalWithTitle.tsx Introduced a new component for a draggable modal with a title, supporting various props for customization and drag handling.
packages/extension-polkagate/src/fullscreen/governance/post/castVote/index.tsx Replaced DraggableModal with DraggableModalWithTitle, integrating title management and adjusting the modal's close logic.
packages/extension-polkagate/src/fullscreen/partials/ModalTitleWithDrag.tsx Added a new component for a draggable title bar in modals, supporting drag events and conditional rendering of icons.
packages/extension-polkagate/src/fullscreen/governance/delegate/index.tsx Replaced DraggableModal with DraggableModalWithTitle, enhancing modal functionality with title and icon props.
packages/extension/polkagate/src/fullscreen/governance/delegate/delegate/Delegate.tsx Adjusted layout and font sizes for Convictions component, refined state management in useEffect, and simplified event handling functions.
packages/extension/public/locales/en/translation.json Added new localization keys for token locking and window dragging instructions.

Possibly related PRs

Suggested reviewers

🐰 In the land of code, where changes abound,
A slider now dances, with options profound.
Convictions are clear, with themes that delight,
In light and in dark, they shine ever bright.
So hop along, friends, let’s test and explore,
For in this new world, there’s always much more! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.