PolkaGate / extension

The official extension of PolkaGate. A user-friendly wallet for seamless browser-based interaction with Polkadot/Substrate-based blockchains.
https://polkagate.xyz
Apache License 2.0
2 stars 5 forks source link

fix: fee issue utilizing fee hook #1679

Closed Nick-1979 closed 1 day ago

Nick-1979 commented 3 days ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 days ago

Walkthrough

The pull request includes extensive modifications across multiple components, primarily focusing on the integration of the useEstimatedFee hook to streamline the estimated fee calculation process. This change replaces various state management approaches with direct hook usage, enhancing type safety and simplifying the code structure. The updates affect components related to governance, staking, and account management, ensuring consistent handling of transaction fees and improving overall clarity in the codebase.

Changes

File Path Change Summary
packages/extension-polkagate/src/fullscreen/accountDetails/unlock/Review.tsx Adjusted imports; replaced estimatedFee state with useEstimatedFee hook for fee calculation.
packages/extension-polkagate/src/fullscreen/governance/delegate/index.tsx Updated fee handling to wrap partialFee in api.createType('Balance', ...) for type consistency.
packages/extension-polkagate/src/fullscreen/governance/delegate/modify/ModifyDelegate.tsx | Enhanced type safety with new type imports; updated fee calculation logic to useapi.createTypeforestimatedFee`.
packages/extension-polkagate/src/fullscreen/governance/delegate/remove/RemoveDelegate.tsx | UpdatedpartialFeehandling to ensure it is typed asBalance`.
packages/extension-polkagate/src/fullscreen/governance/post/castVote/Cast.tsx | Modified fee calculation to wrappartialFeeinapi.createType('Balance', ...)`.
packages/extension-polkagate/src/fullscreen/governance/post/castVote/index.tsx | RemovedestimatedFeestate; replaced withuseEstimatedFee` hook for fee calculation.
packages/extension-polkagate/src/fullscreen/governance/post/decisionDeposit/index.tsx | ReplacedestimatedFeestate withuseEstimatedFeehook; adjustedSignArea2component'saddress` prop.
packages/extension-polkagate/src/fullscreen/manageProxies/Review.tsx | Removed@ts-nocheck; replacedestimatedFeestate withuseEstimatedFee` hook; updated API method access with optional chaining.
packages/extension-polkagate/src/fullscreen/socialRecovery/Review.tsx | RemoveduseEffect; replacedestimatedFeewithuseEstimatedFee` hook; updated transaction handling logic.
packages/extension-polkagate/src/fullscreen/stake/pool/commonTasks/SetState.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/fullscreen/stake/pool/commonTasks/manageValidators/Review.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/fullscreen/stake/solo/commonTasks/manageValidators/Review.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/fullscreen/stake/solo/fastUnstake/index.tsx | RemovedBalanceimport; replacedestimatedFeestate withuseEstimatedFee` hook.
packages/extension-polkagate/src/fullscreen/stake/solo/pending/index.tsx | ChangedExpandedRewardsfrom interface to tuple type; updatederaIndextype fromnumbertostring`.
packages/extension-polkagate/src/fullscreen/stake/solo/restake/index.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/hooks/useIdentity.ts Updated formatted parameter type to include null.
packages/extension-polkagate/src/popup/account/unlock/Review.tsx | RemovedChainandBalanceimports; replacedestimatedFeestate withuseEstimatedFee` hook.
packages/extension-polkagate/src/popup/manageProxies/Review.tsx | Removed@ts-nocheck; replacedestimatedFeestate withuseEstimatedFee` hook.
packages/extension-polkagate/src/popup/send/Review.tsx | RemovedReviewcomponent entirely; simplifiedTo` component.
`packages/extension-polkagate/src/popup/send/partial/SendTxDetail.tsx Component removed.
packages/extension-polkagate/src/popup/staking/partial/SelectValidatorsReview.tsx | RemovedBalanceandBN_ONEimports; replacedestimatedFeestate withuseEstimatedFee` hook.
packages/extension-polkagate/src/popup/staking/pool/myPool/SetState.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/popup/staking/pool/nominations/remove/index.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/popup/staking/pool/redeem/index.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/popup/staking/pool/rewards/Stake.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/popup/staking/pool/rewards/Withdraw.tsx | ReplacedestimatedFeestate withuseEstimatedFee` hook; removed previous fee calculation logic.
packages/extension-polkagate/src/popup/staking/pool/stake/bondExtra/Review.tsx | Added new type imports; refinedtotalStaked` calculation logic.
packages/extension-polkagate/src/popup/staking/pool/stake/createPool/index.tsx | Enhanced type safety forestimatedFeeandestimatedMaxFee`.
packages/extension-polkagate/src/popup/staking/pool/unstake/Review.tsx | AddedBNtype; updatedPropsinterface withstakedandtotal` properties.
packages/extension-polkagate/src/popup/staking/pool/unstake/index.tsx | UpdatedestimatedFee` handling and type assertions; refined alert handling logic.

Possibly related PRs

Suggested labels

change requested

Suggested reviewers


📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 6b58042633ac430e31735b04755081a576e3a104 and a24f3e8ce33f77deaa291179031d71961b84d69f.
📒 Files selected for processing (2) * `packages/extension-polkagate/src/fullscreen/accountDetails/unlock/Review.tsx` (3 hunks) * `packages/extension-polkagate/src/popup/account/unlock/Review.tsx` (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (2) * packages/extension-polkagate/src/fullscreen/accountDetails/unlock/Review.tsx * packages/extension-polkagate/src/popup/account/unlock/Review.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.