fix: infinit loop issue in Edit pool FS, negative number at unstake

Walkthrough

The pull request introduces several modifications across multiple components in the PolkaGate extension. Key changes include refactoring function declarations to named exports and wrapping components with React.memo for performance improvements. The Edit and Review components have undergone significant restructuring, including the introduction of a custom hook in Review for transaction preparation. Type safety enhancements have been made, particularly in state management. Error handling and initialization logic have also been refined, while the overall functionality of the components remains consistent.

Changes

File	Change Summary
`packages/extension-polkagate/src/fullscreen/stake/pool/commonTasks/editPool/Edit.tsx`	- Changed `Edit` from default export to named function with a memoized default export. - Clarified `changes` parameter type in `setChanges`. - Updated logic for the next button's disabled state for type safety. - Adjusted `useEffect` hooks.
`packages/extension-polkagate/src/fullscreen/stake/pool/commonTasks/editPool/Review.tsx`	- Extracted transaction preparation logic into `usePoolTransactionPreparation` hook. - Moved `getRole` function outside of `Review`. - Refactored transaction calls for readability. - Wrapped component with `React.memo`.
`packages/extension-polkagate/src/fullscreen/stake/pool/commonTasks/editPool/ShowPoolRole.tsx`	- Changed export statement to wrap `ShowPoolRole` with `React.memo`. - Simplified translation function call.
`packages/extension-polkagate/src/fullscreen/stake/pool/commonTasks/editPool/index.tsx`	- Wrapped `ManageEditPool` in `React.memo` for performance. - No changes to internal logic or props interface.
`packages/extension-polkagate/src/fullscreen/stake/pool/unstake/index.tsx`	- Updated handling of `maxUnlockingChunks` for type safety. - Expanded conditional checks for `api` variable. - Streamlined `estimatedFee` logic. - Modified `onMaxAmount` function for edge cases. - Enhanced error handling.

Assessment against linked issues

Objective	Addressed	Explanation
Resolve infinite loop issue in Edit pool popup (1681)	✅

Possibly related PRs

#1547: Changes in the Review component may relate to the Edit component as both involve modifications to their respective function signatures and the use of hooks.
#1554: Focuses on refactoring components to use React.memo, similar to the changes made in the Edit component.
#1557: Introduction of the SimpleModalTitle component may relate to the changes in the Edit component regarding component structure.
#1594: Changes in handling currency signs may indirectly relate to the Edit component's state management.
#1606: Adjustments to the Divider component's styling may relate to UI consistency across components, including Edit.

Suggested labels

change requested

🐇 "In the meadow where we play,
Changes hop in bright array.
With hooks and memo, swift and neat,
Our code now dances to a beat!
Type safety and clarity, oh what a treat,
Let's celebrate this coding feat!" 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

PolkaGate / extension