PolkaGate / extension

The official extension of PolkaGate. A user-friendly wallet for seamless browser-based interaction with Polkadot/Substrate-based blockchains.
https://polkagate.xyz
Apache License 2.0
2 stars 5 forks source link

feat: add real shared worker #1684

Open AMIRKHANEF opened 1 day ago

AMIRKHANEF commented 1 day ago

Close: #1683

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 day ago

Walkthrough

The pull request introduces significant modifications to the handling of worker contexts within the application. The WorkerContext type is updated from Worker to MessagePort, affecting various functions that interact with workers. The useAssetsBalances function's signature is altered to accept a MessagePort, simplifying error handling. Several asset retrieval functions are updated to use the new port parameter for messaging instead of the global postMessage. Additionally, the WorkerProvider component is transitioned to utilize a SharedWorker, enhancing the communication model. Version updates in package.json and packageInfo.ts reflect these changes.

Changes

File Change Summary
packages/extension-polkagate/src/components/contexts.tsx Updated WorkerContext type from Worker | undefined to MessagePort | undefined.
packages/extension-polkagate/src/hooks/useAssetsBalances.ts Changed worker parameter type from Worker to MessagePort. Removed error handling for worker's onerror event in three callback functions.
packages/extension-polkagate/src/util/workers/shared-helpers/getAssetOnAssetHub.js Added port parameter of type MessagePort. Updated postMessage calls to use port. Added JSDoc comments for type annotations.
packages/extension-polkagate/src/util/workers/shared-helpers/getAssetOnMultiAssetChain.js Added port parameter of type MessagePort. Updated messaging to use port.postMessage. Added JSDoc comments for type annotations.
packages/extension-polkagate/src/util/workers/shared-helpers/getAssetOnRelayChain.js Added port parameter of type MessagePort. Changed to async/await syntax for asynchronous operations. Enhanced error handling with early returns.
packages/extension-polkagate/src/util/workers/shared-helpers/getBalances.js Added port parameter of type MessagePort. Updated messaging to use port.postMessage. Refactored property access from dot notation to bracket notation.
packages/extension-polkagate/src/util/workers/sharedWorker.js Replaced onmessage with onconnect to handle multiple connections. Updated message handling to use port. Enhanced error handling and logging.
packages/extension-ui/src/Popup/contexts/WorkerProvider.tsx Transitioned from Worker to SharedWorker. Updated state variable from worker to port. Modified cleanup and context provider value accordingly.
packages/extension/package.json Updated version from 0.33.0 to 0.33.1.
packages/extension/src/packageInfo.ts Updated version in packageInfo from '0.33.0' to '0.33.1'.
packages/extension-polkagate/src/hooks/useNFT.tsx Replaced Worker instantiation with useWorker hook. Updated message handling and error handling for NFT fetching. Added NftItemsWorker interface.
packages/extension-polkagate/src/util/workers/shared-helpers/getNFTs.js Introduced new functions for fetching NFTs and collections, including error handling and retries.
packages/extension-polkagate/src/util/workers/utils/fastestEndpoint.js Added connectionEndpoint property to connections. Improved logic for connected endpoints and cleanup of not connected endpoints.

Possibly related PRs

Suggested labels

new feature, change requested

🐰 In the land of code where workers play,
A MessagePort leads the way.
With shared tasks and balances fair,
We hop along without a care!
From Worker to SharedWorker, we cheer,
For smoother paths, our goals are clear! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.