search

Polkadex-Substrate / Polkadex-Open-Beta

12 stars 3 forks source link

Error message is shown in green #523

Open DayalKS2 opened 1 year ago

DayalKS2 commented 1 year ago

Error message when user hits BUY PDEX without entering any price is shown in Green (almost like a positive notification). This should be shown in red font like an error message. Also, it needs a fullstop or comma after Order Failed. Currently it says 'Order Failed price cannot be less than min...'. I was thinking what it is 'Order Failed Price' and later realized that the sentence misses a break like 'Order Failed! Price cannot...' onchainaddress:{esp5dCFuAuPi6KD3HzhHWQGjgwiNvyWLp6qJW5EGgo7zkhRBJ} image

DayalKS2 commented 1 year ago

This is same for almost all error messages. These should not be shown in Green. Also, error messages/warnings doesnt need tick mark like success messages. Also, break or Full stop is missing between sentences. image

jaymansfield commented 1 year ago

487

ap211unitech commented 1 year ago

Here is the PR - https://github.com/Polkadex-Substrate/Polkadex-Orderbook-Frontend/pull/663