coderabbitai[bot]
commented
3 months ago [!IMPORTANT]
Review skipped
Review was skipped due to path filters
Files ignored due to path filters (3)
* `apps/hestia/package.json` is excluded by `!**/*.json` * `packages/core/package.json` is excluded by `!**/*.json` * `yarn.lock` is excluded by `!**/*.lock`, `!**/*.lock`You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Walkthrough
Recent updates enhance the Form and ConfirmTransaction components, improve validation logic, update error messages, and refine balance formatting. These changes collectively aim to optimize loading states, validation checks, and numeric representations, ensuring a more robust and user-friendly experience.
Changes
| File Path | Change Summary |
|---|---|
apps/hestia/src/components/thea/Form/index.tsx |
Added handling for isDestinationPDEXBalanceLoading and adjusted loading calculation. |
apps/hestia/src/components/thea/confirmTransaction.tsx |
Updated condition logic to include showAutoSwap for amount check against autoSwapAmount. |
packages/core/src/constants/index.ts |
Revised error messages for minimum amount validation. |
packages/core/src/providers/user/thea/index.tsx |
Added isLoading to useTheaBalances and updated state type definition. |
packages/core/src/validations/index.ts |
Added validation rule for values greater than zero and adjusted minimum amount comparison logic. |
packages/format/src/balances.ts |
Switched to parseScientific for numeric conversion and trimmed float values without rounding. |
apps/hestia/src/components/thea/connectAccount.tsx |
Modified useState hook for extension by removing initial null value. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant Form
participant TheaProvider
participant ConfirmTransaction
participant BalanceFormatter
User->>Form: Load Form
Form->>TheaProvider: Get Balances
TheaProvider-->>Form: Return Balances with isLoading
Form->>Form: Calculate loading state
User->>ConfirmTransaction: Confirm Transaction
ConfirmTransaction->>ConfirmTransaction: Check showAutoSwap and amount
User->>BalanceFormatter: Format Balance
BalanceFormatter->>BalanceFormatter: Parse Scientific and Trim FloatPoem
In the land of code where numbers play,
We trim and parse in a scientific way.
Balances load without delay,
Validations keep the errors at bay.
Polkadex flows in a seamless dance,
A rabbit's touch, enhancing the chance.
To make our app a true romance.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
netlify[bot]
Description
Currently, the Bridge page supports all the chains and assets that we had in old THEA UI. Now, we will be expanding cross-chain transfers process. Most of the chains that we have right now, have some non-native assets which are already supported by Polkadex network. Our task is to allow those tokens to be deposited in Polkadex chain so that user can start trading easily.
In this task, we will be allowing these assets from Interlay network -
This way, If user have these assets on Interlay network, they can directly transfer thier selected asset to Polkadex network and start trading. They can withdraw it back as well.
Checklist