search

Polkadex-Substrate / Polkadex-Orderbook-Frontend

https://orderbook.polkadex.trade
3 stars 3 forks source link

Direct Deposits/Withdrawals - Static Page #1329

Closed minikas closed 2 months ago

minikas commented 2 months ago

Description

This PR transforms the current deposit/withdraw page to align with the new design prototype.

Note: This PR only addresses the static page/interaction with mocks

Changes Made

Screenshots / Screencasts

Screenshot 2024-06-19 at 10 33 49

Checklist

Close: https://github.com/Polkadex-Substrate/Polkadex-Orderbook-Frontend/issues/1328

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent changes introduce functionality to manage direct deposits and withdrawals in the Hestia app. This includes displaying transaction history, exporting data to CSV, handling asset and wallet selection, and managing deposit and withdrawal processes. New components simplify user interaction with clean UI elements for each task, ensuring efficient and intuitive navigation.

Changes

Files Change Summary
apps/.../columns.tsx Introduced columns for displaying transaction data in a table format.
apps/.../export.tsx Added Export component to handle exporting bridge history data to a CSV file.
apps/.../linkCard.tsx Added LinkCard component to generate clickable link cards with truncated data and external link icons.
apps/.../faq.tsx Added Faq component to display a list of fake news items with titles and links.
apps/.../selectAsset.tsx Added SelectAsset component to manage asset selection from a list.
apps/.../deposit.tsx Added Deposit component for managing deposits, including selecting networks, assets, amounts, and addresses.
apps/.../selectWallet.tsx Added SelectWallet component for selecting wallets, integrating with extensions and account management.
apps/.../withdraw.tsx Added Withdraw component to facilitate asset withdrawal, including network selection, asset choice, and amount input.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HestiaApp
    participant Wallet
    participant CSVDownloader

    User->>HestiaApp: Connect Wallet
    HestiaApp->>Wallet: Fetch Wallet Details
    Wallet-->>HestiaApp: Return Wallet Details
    User->>HestiaApp: Select Network and Asset
    User->>HestiaApp: Deposit or Withdraw Asset
    User->>HestiaApp: View Transaction History
    User->>HestiaApp: Export History to CSV
    HestiaApp->>CSVDownloader: Prepare CSV Data
    CSVDownloader-->>User: Download CSV File

Assessment against linked issues

Objective (from #1328) Addressed Explanation
User connects the wallet >> go to deposits page >> select the network >> select the asset >> click deposit ✅
Show History ✅
Show Progress ✅
Address component should be displayed to the user only in the case of EVM wallets ❓ Review for conditional display based on wallet type is required.

Poem

In Hestia's realm, the wallets connect, With assets to choose and networks to select. Deposit and withdraw, history in view, Export to CSV, all functions are new. A seamless journey, so smooth and bright, For users of Polkadex, day and night. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 months ago

Deploy Preview for stupendous-valkyrie-505e4a failed. Why did it fail? →

Name Link
Latest commit 0e5a32bf250bb5bbb6248ca9c57d364471cee7e7
Latest deploy log https://app.netlify.com/sites/stupendous-valkyrie-505e4a/deploys/667374e796ba4000082213e7
ap211unitech commented 2 months ago

Please fix CI

ap211unitech commented 2 months ago

@minikas I think, once we have these pages, we no more require transfer page. So, I think we should remove those links from UI and delete those pages/component from codebase. What's your take on this ?

CC: @nuel77