Closed ap211unitech closed 2 months ago
[!IMPORTANT]
Review skipped
Review was skipped due to path filters
Files ignored due to path filters (1)
* `yarn.lock` is excluded by `!**/yarn.lock`, `!**/*.lock`, `!**/*.lock`You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The changes primarily introduce and update functionality related to deposits, withdrawals, and asset management within the Hestia app. New components and hooks for handling direct deposit and withdrawal processes are added, while existing paths and import statements are updated to support these features. Several components are refined with state management and validation logic improvements to enhance user interactions and streamline transaction flows.
File(s) | Change Summary |
---|---|
apps/.../send-and-receive/layout.tsx apps/.../send-and-receive/page.tsx |
Introduction of layout and page components for send-and-receive functionality. |
apps/.../balances/Overview/index.tsx apps/.../balances/Table/columns.tsx apps/.../balances/Table/responsiveTable.tsx |
Updated href paths and query parameters for deposit, withdrawal, and transfer actions. |
apps/.../sendAndReceive/History/*.tsx |
Added, updated, and refined components related to transaction history, including filtering, exporting, and loading states. |
apps/.../sendAndReceive/deposit/*.tsx apps/.../sendAndReceive/withdraw/*.tsx |
Introduction of new deposit and withdrawal components with enhanced form handling, transaction confirmations, and UI interactions. |
apps/.../sendAndReceive/*.tsx |
Introduced utility components like FAQ, help, and select asset/network. |
apps/.../ui/ConnectWallet/*.tsx apps/.../ui/Footer/QuickStart/index.tsx apps/.../ui/Header/fundWalletModal.tsx |
Updated href paths and improved content for wallet connectivity, funding, and onboarding new users. |
packages/.../core/providers/user/sendAndReceive/withdraw/*.tsx |
Added new provider components and hooks for managing withdrawal processes. |
packages/.../core/providers/user/subscription/provider.tsx |
Modified notification logic for transaction types within subscription provider. |
packages/.../core/validations/index.ts |
Added and updated validation logic for direct deposit and withdrawal processes. |
apps/hestia/hooks/index.ts packages/core/providers/index.ts |
Exported new hooks and providers for direct deposit and withdrawal functionalities. |
sequenceDiagram
participant User
participant HestiaApp
participant DirectDepositProvider
participant DirectWithdrawProvider
User->>HestiaApp: Navigates to /send-and-receive
HestiaApp->>DirectDepositProvider: Initialize DirectDepositProvider
HestiaApp->>DirectWithdrawProvider: Initialize DirectWithdrawProvider
User->>HestiaApp: Initiates Deposit
HestiaApp->>DirectDepositProvider: Handle deposit transaction
DirectDepositProvider->>User: Display deposit confirmation
User->>HestiaApp: Initiates Withdrawal
HestiaApp->>DirectWithdrawProvider: Handle withdrawal transaction
DirectWithdrawProvider->>User: Display withdrawal confirmation
Amid the code in Hestia's heart,
Deposits and withdrawals now light the chart.
Paths are smoothed, transactions clear,
With added flows and logic dear.
A rabbit's joy in every byte,
🐇 In the code, the future's bright! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Name | Link |
---|---|
Latest commit | 0f5537872c577b00f87d9566780f5a7a7fbb06d7 |
Latest deploy log | https://app.netlify.com/sites/stupendous-valkyrie-505e4a/deploys/6686c7fee1150f0008cb9639 |
Screen.Recording.2024-06-26.at.05.58.05.mov @nuel77 @ap211unitech I can't withdraw
@minikas You should have DOT in AssetHub network. It will withdraw to AssetHub chain.
Screen.Recording.2024-06-26.at.06.15.16.mov The MAX button works differently in withdraw and deposit.
@minikas What is the issue here ? It's working as expected.
Screen.Recording.2024-06-26.at.06.23.46.mov @ap211unitech Please reset the form when switching networks & assets
@minikas This is added now.
Screen.Recording.2024-06-26.at.05.58.05.mov @nuel77 @ap211unitech I can't withdraw
@minikas You should have DOT in AssetHub network. It will withdraw to AssetHub chain.
Screen.Recording.2024-06-26.at.05.58.05.mov @nuel77 @ap211unitech I can't withdraw
@minikas You should have DOT in AssetHub network. It will withdraw to AssetHub chain.
@ap211unitech DOT to pay the fee or for existential purposes, or exactly why? @nuel77 Shouldn't we inform the user about this (maybe a component with this kind of information)?
Screen.Recording.2024-06-26.at.05.58.05.mov @nuel77 @ap211unitech I can't withdraw
@minikas You should have DOT in AssetHub network. It will withdraw to AssetHub chain.
Screen.Recording.2024-06-26.at.05.58.05.mov @nuel77 @ap211unitech I can't withdraw
@minikas You should have DOT in AssetHub network. It will withdraw to AssetHub chain.
@ap211unitech DOT to pay the fee or for existential purposes, or exactly why? @nuel77 Shouldn't we inform the user about this (maybe a component with this kind of information)?
@minikas Whenever we do a bridge transfer, Destionation account must have existential amount in destination chain else bridge ttransfer will fail.
📝 Description
We have already created packages for enabling direct deposits and withdrawal. Now, next task is to integrate them with UI so that direct deposits/withdrawal could be done from UI.
With Direct deposit, we can deposit tokens from any foreign chain to polkadex orderbook. With Direct withdraw, we can withdraw tokens from polkadex orderbook to any foreign chain.
Tasks -
Note -
CI is failing due to netlify issue. Build is successful.
Checklist