When reviewing this PR, focus on the polkadex code related changes - this PR should not include any functionality changes in the polkadex specific code. Also, there are many file changes / additions that can be skipped over because they are not used by polkadex. Examples:
sidechain
stf (except the cli part)
top_pool
Also, files that are newly created do not cause merge conflicts, so it is safe to assume that they do not introduce errors as they have been reviewed previously by integritee.
[x] compile code -> fix all errors that pop up along the way
[x] rebase to current develop branch
[x] merge sgx-runtime & change dependencies to point to master (blocked by task 2)
[x] cargo fmt
[x] Bigna: compare diff again -> any polkadex things changed?
[x] fix clippy warnings
-> I removed all clippy warnings that are caused by this PR, but there are some warnings left which are already in the develop branch and/or newly popped up due to the addition of the "test" feature (some functions are only used in tests, even though they are not marked as such..)
I will create a separate issue for that -> https://github.com/Polkadex-Substrate/polkadexTEE-worker/issues/303
[x] fix unit tests
[x] test if worker & node can still talk with each other
[ ] integration testing (@zktony ?)
For some files/constructs there has been a new concept introduced, which would require many changes in the code introduced by polkadex. Because of the hugeness of this PR I avoided complicated ingegration, and simply renamed the file to "polkadex_..." or added a FIXME comment. These files / functions should be integrated into the new construction. But in a separate PR so these changes will not be missed and can be reviewed properly.
This concerns the following files:
worker/src/ipfs_polkadex.rs (new file: worker/src/ocall_bridge/ipfs_ocall.rs)
worker/src/direct_incovation/polkadex_direct_server.rs (see files in same folder)
alot of ocalls / ecalls should be moved to the ffi folder
Updates to substrate septemeber + 1 tag and merges some updates from integritee master Status of integritee master: 19 august , commit https://github.com/integritee-network/worker/commit/ed8628ef2d33f5aec94de413e19fc38c30d328fa
When reviewing this PR, focus on the polkadex code related changes - this PR should not include any functionality changes in the polkadex specific code. Also, there are many file changes / additions that can be skipped over because they are not used by polkadex. Examples:
sidechainstf(except the cli part)top_poolAlso, files that are newly created do not cause merge conflicts, so it is safe to assume that they do not introduce errors as they have been reviewed previously by integritee.
TODOs:
For some files/constructs there has been a new concept introduced, which would require many changes in the code introduced by polkadex. Because of the hugeness of this PR I avoided complicated ingegration, and simply renamed the file to "polkadex_..." or added a FIXME comment. These files / functions should be integrated into the new construction. But in a separate PR so these changes will not be missed and can be reviewed properly. This concerns the following files:
I will create separate issues for these matters.