search

PollardBanknote / qdiffdir

A Qt Directory Comparison Tool
Other
0 stars 0 forks source link

mgdiff doesn't open .gz files #38

Open gemmell-x opened 7 years ago

gemmell-x commented 7 years ago

Certain diff programs do not open certain archived file types. The issue occurred because mgdiff could not open a .gz file.

qdiffdir should identify which diff programs are incompatible with which archived file types and create an uncompressed temp version of that file for diffing.

jlee975 commented 7 years ago

I'm not sure it should be the responsibility of qdiffdir to know about every diff program

The solution you mentioned earlier could be used for any diff tool: extract it to a temp and compare. That's all gvimdiff does anyway.

It would be needed for #32 anyway

jlee975 commented 7 years ago

If you have code, @gemmell-x, it's best to create a branch and push it. I'll review and merge.

jlee975 commented 6 years ago

Since gz files are now handle through the "match rule" feature, this will probably be simpler