search

Polly-Contrib / Polly.Contrib.DuplicateRequestCollapser

A Polly policy to collapse concurrent duplicate requests to a single execution.
Other
18 stars 3 forks source link

Fix RequestCollapserEngine caching lazy with exceptions as value indefinitely #6

Closed Allen-Xiao closed 4 years ago

Allen-Xiao commented 4 years ago

When the valueFactory inside a Lazy object throws an exception, the collapser engine is not properly cleaning it up from the ConcurrentDictionary. This results in the RequestCollapserPolicy caching the result indefinitely.

jjxtra commented 4 years ago

@reisenberger Would love your input

jjxtra commented 4 years ago

How do we get an updated nuget built?

jjxtra commented 4 years ago

@veleek @reisenberger Either of you able to do the nuget voodoo for this? I think v. 0.3.0 would be the next version.

veleek commented 4 years ago

I do not. I'm assuming everybody in the https://github.com/orgs/Polly-Contrib/people group have access.

joelhulen commented 4 years ago

@jjxtra I'll help you out with the package deployment. Taking a look now.

joelhulen commented 4 years ago

@jjxtra I've deployed the NuGet package. The package version is 0.2.1. It should post soon.

The NuGet auth key had expired, so I updated it in AppVeyor, which is what we use for CI/CD.

jjxtra commented 4 years ago

@joelhulen Thank you so much for your assistance!

joelhulen commented 4 years ago

Of course! Thank you for your contribution :)