Support for Polly v8 Please

Polly-Contrib / Polly.Contrib.DuplicateRequestCollapser

A Polly policy to collapse concurrent duplicate requests to a single execution.

Other

17 stars 3 forks source link

Support for Polly v8 Please #8

Open taspeotis opened 10 months ago

taspeotis commented 10 months ago

The NuGet package prevents this package from restoring with Polly v8, could support for Polly v8 please be added? Thank you.

mzcatcher commented 10 months ago

hello, is there any progress ?

cmeeren commented 9 months ago

+1, AFAIK it's backwards compatible, so this is likely a metadata-only update. would very much like Polly 8 to be supported.

realgio95 commented 8 months ago

I echo the above!

ernesto1596 commented 8 months ago

@jjxtra / @joelhulen would either of you be able to help out with this? This seems like it mainly requires re-generating the nuget to support 8.0.0.

jjxtra commented 8 months ago

Have sent a commit to master.

realgio95 commented 8 months ago

Can we also target earlier versions of .Net by any chance?

realgio95 commented 8 months ago

Especially since .net 6 is the one with longterm support

jjxtra commented 8 months ago

Done. The nuget itself is netstandard2.0.

realgio95 commented 8 months ago

thank you @jjxtra . Let us know once publlished and we'll test uptake. Thank u so much

jjxtra commented 8 months ago

@reisenberger Can you publish nuget 0.3.0?

realgio95 commented 8 months ago

Hasnt been published yet. Can anyone else publish or has access to publish? @jjxtra cc @reisenberger

jjxtra commented 8 months ago

I cannot

realgio95 commented 8 months ago

Ah okay. Anyone other contributor has access to? or just @reisenberger ?

realgio95 commented 8 months ago

https://ci.appveyor.com/project/Polly-Contrib/polly-contrib-duplicaterequestcollapser/builds/48658998

realgio95 commented 8 months ago

We encountering another issue that will be resolved by this deployment:

there is no version of Polly.RateLimiting <8.0.0
Polly.RateLimiting brings dependency on Polly.Core 8
Polly.Core 8 has some of the objects of Polly 7, causing conflicts :(

jjxtra commented 8 months ago

Have uploaded a custom nuget of this as DigitalRuby.Polly.Contrib.DuplicateRequestCollapser.

If @reisenberger wants to respond, we can try to fix the build and get this deployed with the original Polly.Contrib.DuplicateRequestCollapser package name.

Kirtlander commented 7 months ago

@joelhulen, would you be able to publish the latest change making DuplicateRequestCollapser compatible with Polly v8 to NuGet? We see you were the last to publish a release of this project. My company is still using this and find it quite useful. Thank you in advance.

nzdev commented 5 months ago

I've updated this to use the V8 syntax if someone would like to review / publish a new nuget package. https://github.com/Polly-Contrib/Polly.Contrib.DuplicateRequestCollapser/pull/9.

joelhulen commented 5 months ago

@Kirtlander, sorry, I just saw your message from January. I get tons of GitHub emails every day. I'll try and publish now.

joelhulen commented 5 months ago

@nzdev and @Kirtlander, the I've merged the PR, but the build is currently failing with Failed to install addin 'Cake.FileHelpers'.: https://ci.appveyor.com/project/Polly-Contrib/polly-contrib-duplicaterequestcollapser/builds/49352636. If one of you can address this and get a successful build, I'll publish the NuGet package.

howej commented 5 months ago

Hi @nzdev and @Kirtlander, any update on this?

nzdev commented 4 months ago

https://github.com/Polly-Contrib/Polly.Contrib.DuplicateRequestCollapser/pull/10 Fixed the build @joelhulen

AndreaCuneo commented 1 month ago

@joelhulen any chance to release this anytime soon?

akashsinghal commented 2 weeks ago

+1 would be great to have a release