search

Polly-Contrib / Polly.Contrib.WaitAndRetry

Polly.Contrib.WaitAndRetry is an extension library for Polly containing helper methods for a variety of wait-and-retry strategies.
Other
133 stars 12 forks source link

No package on nuget? #9

Closed hyrmn closed 5 years ago

hyrmn commented 5 years ago

I read (and sort of understood) the genesis of this lib over on Polly #530. I love love that all of that jitter work has found its own home. But, when I click through on the nuget badge to https://www.nuget.org/packages/Polly.Contrib.WaitAndRetry, I get an oops page. Since there's nothing in the search, I assume this package isn't currently published? What is the recommended consumption model?

reisenberger commented 5 years ago

@hyrmn @grant-d This package Polly.Contrib.WaitAndRetry has no how-to-use documentation (#5). I believe we should have minimal documentation describing the overloads/contents/how-to-use in the readme, before releasing. Can somebody add that? We'd love to package this up for release then!

@hyrmn This doesn't include the jitter (EDIT: the revised jitter of Polly issue 530) yet.

hyrmn commented 5 years ago

thanks @reisenberger.

If @grant-d doesn't mind, I'd be happy to make an initial PR on #5 (I see it's up for grabs), and then it can be tweaked from there. I'm sure I'll make some mistakes but the code doc comments are very complete.

grant-d commented 5 years ago

Go for it! The more (help) the merrier

grant-d commented 5 years ago

Sorry all, been on sabbatical so haven't looked at any code for quite some time. Am back at it next month.

reisenberger commented 5 years ago

Awesome, @hyrmn ! Thanks for helping the community forward! And: thanks @grant-d for your original contribution!

reisenberger commented 5 years ago

@hyrmn @grant-d I made PR #11 to bring George Polevoy's new jitter formula in to this repo! 🎉

@hyrmn If you get a mo for the doco on the existing formulae, I can follow on with the doco for the new jitter formula if you like/helpful, as I dove deep on that. Thanks!

hyrmn commented 5 years ago

Sorry, I meant to get to this yesterday @reisenberger. I will have a start for you tonight! I'm quite excited to have the jitter stuff

reisenberger commented 5 years ago

@hyrmn @grant-d Polly.Contrib.WaitAndRetry v1.0.0 has been published to nuget, and will be available for download as soon as nuget has finished indexing it. Thanks for everything you have contributed.