Closed cristoferjimenez closed 1 year ago
The PollyPreprocess.m function was modified to consider the measurement time instead of the measurement shots to avoid trigger issues in the resampling of the data
Hi, Cristofer. Thanks for your contribution.
I would need some assist to continue the code review. Could you (@cristoferjimenez & @HolgerPollyNet ) explain a little bit about the trigger issue
and resampling data
?
What do you mean by trigger issue
? Is it something assosicated with wrong measurement shots?
And does resampling data
associated with higher temporal resolution dataset (e.g., 10 s)?
So far, the preprocessing module has very complex logic flow to be compatible with different sort of old Polly data. Therefore, I need to be very careful with new update.
Hi Zhenping,
Yes, of course... With this trigger issue, I mean that sometimes, not all laser shots are being detected by the acquisition system, which might be an issue coming from the optical trigger we have (optical fiber connecting the emission site to the acquisition device). Why not all shots are being detected is not quite clear, it could be a misalignment of this fiber or a drop in the energy of the laser. In any case, by using the number of shots to know the temporal resolution is producing a wrong resampling of data, which is already in 30 seconds resolution. Therefore I propose to use the measurement time instead of the measurement shots to know the temporal resolution.
Thank you for taking care.
The PollyPreprocess.m function was modified to consider the measurement time instead of the measurement shots to avoid trigger issues in the resampling of the data