search

PollyNET / Pollynet_Processing_Chain

NRT lidar data processing program for multiwavelength polarization Raman lidar network (PollyNET)
https://polly.tropos.de/
GNU General Public License v3.0
19 stars 8 forks source link

Issue #196 ... implement 1-step Poliphon #223

Closed AthenaAugousta closed 10 months ago

AthenaAugousta commented 10 months ago

Hey @HolgerPollyNet, could you check how it performs now?

HolgerPollyNet commented 10 months ago

Unfortunately it did not work out:

2023-08-29 14:05:26] {Undefined function or variable "aerBsc532_klett_d1".

Error in poliphon_one (line 198) POLIPHON1.aerBsc532_klett_d1 = aerBsc532_klett_d1;

Error in picassoProcV3 (line 2847) [POLIPHON1] = poliphon_one ...

HolgerPollyNet commented 10 months ago

Good news. With the latest version, the chain is running without problems and nc files are created!

Great!!!

Now the picky things: Could you please homogenize the variable names in the output? Currently we use uncertainty*** for the error estimates but you used err***.

Could you rename it? At a certain point we may think about the names in general, but for now it would be great to keep some consistency.

HolgerPollyNet commented 10 months ago

In general, but maybe for a future version it would be also great to source out everything that could be adjusted to the config file.

In your case it would be: Dd = [0.23, 0.31, 0.25]; Dnd = [0.05, 0.05, 0.05];

If you like you can try by now or in a later version.

AthenaAugousta commented 10 months ago

That's great to hear!

Thanks for pointing out the naming inconsistency, I will change it accordingly. Also, if you find something else that can be improved, please let me know.

HolgerPollyNet commented 10 months ago

Congratulations, the new commit worked without problems! @AthenaAugousta

You did a great job and accomplished to implement a new product to the PPC. This qualifies you to give the next PollyNET webinar under the tentative title: Adding new products/features to PollyNET Processing Chain - experiences from a newcomer" ;-) - which I think would be really warmly welcomed by all the other who want to contribute but do not yet really know how to start!