search

PollyNET / Pollynet_Processing_Chain

NRT lidar data processing program for multiwavelength polarization Raman lidar network (PollyNET)
https://polly.tropos.de/
GNU General Public License v3.0
20 stars 8 forks source link

add keyword to control the z-axis of vol-depol colorplot #62

Closed HolgerPollyNet closed 4 years ago

HolgerPollyNet commented 4 years ago

I updated only the 2 files pollyxt_display_rcs.m and .py to allow for adjusting the z-scale for the volume depol time-height plots. Please forget about the other files.....globa config was also adjusted with respect to that....

ZPYin commented 4 years ago

Please try to name the PRs properly, in case it can be easily searched in future.

i.e., add keyword to control the z-axis of vol-depol colorplot for this PR

HolgerPollyNet commented 4 years ago

I pushed the new commits to Holger, how can I conclude them in this pull request?

ZPYin commented 4 years ago

I pushed the new commits to Holger, how can I conclude them in this pull request?

It has been updated automatically. I will merge it and then start testing phase.

Done! The PRs has been Pushed to the server and running well.

ZPYin commented 4 years ago

BTW, another tip: please pull the latest dev branch and merge it locally before you send the PRs.

By this way, it can make sure you resolved all conflicts in the first place. Otherwise, it will cost extra time for code viewers to think about what should be remained.

HolgerPollyNet commented 4 years ago 
Thanks you are completely right! I will do this. I also used git gui
this time and obviously it was not working so well like the command
line approach.....

Is the option already implemented at the server? Or do you have
developments ongoing prohibiting this?

Thanks
Holger

Am 10.06.2020 um 02:04 schrieb ZPYin:

  BTW, another tip: please pull the latest dev
    branch and merge it locally before you send the PRs.
  By this way, it can make sure you resolved all conflicts in the
    first place. Otherwise, it will cost extra time for code viewers
    to think about what should be remained.
  —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub, or unsubscribe.
  [

{ "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/PollyNET/Pollynet_Processing_Chain/pull/62#issuecomment-641642511", "url": "https://github.com/PollyNET/Pollynet_Processing_Chain/pull/62#issuecomment-641642511", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

--

Dr. Holger Baars (Dipl.-Met.) Leibniz Institute for Tropospheric Research (TROPOS) Permoserstr. 15 04318 Leipzig, Germany phone: ++49 341 2717 7314 fax: ++49 341 2717 99 7314 email: baars@tropos.de internet: http://www.tropos.de

ZPYin commented 4 years ago

Is the option already implemented at the server? Or do you have developments ongoing prohibiting this?

It has been implemented in the server, but at the dev branch only. Make sure you are working at the dev branch if you want to use this setting.