search

PollyNET / Pollynet_Processing_Chain

NRT lidar data processing program for multiwavelength polarization Raman lidar network (PollyNET)
https://polly.tropos.de/
GNU General Public License v3.0
20 stars 8 forks source link

storage of water vapor quality mask #63

Closed HolgerPollyNet closed 4 years ago

HolgerPollyNet commented 4 years ago

please review! Then i can change all the other main functions of diffeent polly systems

HolgerPollyNet commented 4 years ago

Sure looks good, go for IT ____sure ____ Von: ZPYin [notifications@github.com] Gesendet: Donnerstag, 11. Juni 2020 15:08 An: PollyNET/Pollynet_Processing_Chain Cc: Holger Baars; Author Betreff: Re: [PollyNET/Pollynet_Processing_Chain] I added the storage of water vapor quality mask (#63)

@ZPYin commented on this pull request.

In lib/polly_general_func_lib/pollyxt_save_WVMR_RH.mhttps://github.com/PollyNET/Pollynet_Processing_Chain/pull/63#discussion_r438768005:

@@ -55,7 +57,10 @@ function pollyxt_save_WVMR_RH(data, taskInfo, config) netcdf.putVar(ncID, varID_time, datenum_2_unix_timestamp(data.mTime)); netcdf.putVar(ncID, varID_WVMR, fillmissing(data.WVMR, missing_value)); netcdf.putVar(ncID, varID_RH, fillmissing(data.RH, missing_value));

+try

  • netcdf.putVar(ncID, varID_QM_WVMR, fillmissing(data.quality_mask_WVMR, missing_value));
  • netcdf.putVar(ncID, varID_QM_RH, fillmissing(data.quality_mask_RH, missing_value)); +end

would it be better to use "if ... else..." here? See the code below.

if isfield('data', 'quality_mask_WVMR') netcdf.putVar(ncID, varID_QM_WVMR, fillmissing(data.quality_mask_WVMR, missing_value)); end

if isfield('data', 'quality_mask_RH') netcdf.putVar(ncID, varID_QM_RH, fillmissing(data.quality_mask_RH, missing_value)); end

I think it delivers clear meaning and is more friendly for future improvement.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/PollyNET/Pollynet_Processing_Chain/pull/63#pullrequestreview-428888834, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANJXHY4XZWXKG6W2BA4DC7TRWDJOJANCNFSM4N3MGOCA.

HolgerPollyNet commented 4 years ago

I pushed a new version, but I am not sure if the way I am doing int now is interferring wiht the

"% re enter define mode netcdf.reDef(ncID);"

command.

Can you review?

HolgerPollyNet commented 4 years ago

new version online, i also fixed some bugs (latitude), please check

ZPYin commented 4 years ago

I fixed a minor bug when testing (see 0c13ffd). Now you can pull the dev branch and extend the feature to all pollyxts.