PoloNX / SimpleModDownloader

A switch homebrew which downloads mods from gamebanana
GNU General Public License v3.0
127 stars 18 forks source link

[BUG] Some crash #58

Closed DeathNorn closed 3 months ago

DeathNorn commented 3 months ago

Describe the bug Whenever I try to install any mod it crashes the app I believe it is because of the image loading in as soon as you click on the mod. It didn’t do this for the earlier version since you could choose to load the images.

On which mod All of them mod whenever it fells like it.

Log file Paste the log file here (you can find it at /config/SimpleModDownloader/log.log) Don't launch the app again before pasting the log file, it will be overwritten

18:43:24.104[INFO] switch system theme: Dark 18:43:24.105[INFO] Using platform Switch 18:43:24.172[INFO] glfw: GL Vendor: nouveau 18:43:24.172[INFO] glfw: GL Renderer: NV120 18:43:24.172[INFO] glfw: GL Version: 4.3 (Core Profile) Mesa 20.1.0-rc3 18:43:24.172[INFO] glfw: GLFW Version: 3.3.4 18:43:24.220[INFO] glfw: Monitor: Default 18:43:24.221[DEBUG] Vibration clear #0 18:43:24.221[DEBUG] Vibration clear #1 18:43:24.221[DEBUG] Vibration clear #2 18:43:24.221[DEBUG] Vibration clear #3 18:43:24.221[DEBUG] Vibration clear #4 18:43:24.221[INFO] switch system locale: en-US 18:43:24.221[WARNING] Cannot find custom font, (Searched at: romfs:/font/font.ttf) 18:43:24.225[DEBUG] Adding an inputs block token (tokens=1) 18:43:24.574[DEBUG] 49 games found 18:43:24.577[DEBUG] Cell #0 - added 18:43:24.599[DEBUG] Cell #1 - added 18:43:24.615[DEBUG] Cell #2 - added 18:43:24.646[DEBUG] Cell #3 - added 18:43:24.666[DEBUG] Cell #4 - added 18:43:24.689[DEBUG] Cell #5 - added 18:43:24.689[DEBUG] Giving focus to brls::SidebarItem 18:43:24.692[DEBUG] Hiding brls::AppletFrame (id="applet") 18:43:24.692[DEBUG] push activity to the stack 18:43:24.692[DEBUG] Showing brls::AppletFrame (id="applet") 18:43:24.692[INFO] AppletFocusState_InFocus 18:43:24.806[INFO] Window size changed to 1280x720, content size: 1280x720 factor: 1 18:43:24.806[INFO] scale factor: 1 18:43:24.926[DEBUG] Removing an inputs block token (tokens=0) 18:43:25.679[DEBUG] Giving focus to brls::SidebarItem 18:43:26.629[DEBUG] Giving focus to brls::SidebarItem 18:43:27.095[DEBUG] Giving focus to brls::SidebarItem 18:43:27.696[DEBUG] Giving focus to brls::SidebarItem 18:43:28.206[DEBUG] Giving focus to brls::SelectorCell (id="language_selector") 18:43:28.556[DEBUG] Giving focus to brls::BooleanCell (id="debug_cell") 18:43:29.074[INFO] Open the debug layer 18:43:30.874[INFO] Close the debug layer 18:43:31.556[DEBUG] Giving focus to brls::SidebarItem 18:43:31.928[DEBUG] Giving focus to brls::SidebarItem 18:43:32.579[DEBUG] Giving focus to brls::SidebarItem 18:43:32.985[DEBUG] Giving focus to brls::SidebarItem 18:43:36.479[DEBUG] Giving focus to brls::SidebarItem 18:43:36.795[DEBUG] Giving focus to brls::SidebarItem 18:43:37.633[DEBUG] 49 games found 18:43:37.636[DEBUG] Cell #0 - added 18:43:37.659[DEBUG] Cell #1 - added 18:43:37.677[DEBUG] Cell #2 - added 18:43:37.703[DEBUG] Cell #3 - added 18:43:37.725[DEBUG] Cell #4 - added 18:43:37.749[DEBUG] Cell #5 - added 18:43:37.749[DEBUG] Giving focus to brls::SidebarItem 18:43:38.490[DEBUG] Giving focus to GameCell 18:43:38.840[DEBUG] Giving focus to GameCell 18:43:39.107[DEBUG] Giving focus to GameCell 18:43:39.172[DEBUG] Cell #0 - destroyed 18:43:39.390[DEBUG] Giving focus to GameCell 18:43:39.462[DEBUG] Cell #6 - added 18:43:39.489[DEBUG] Cell #1 - destroyed 18:43:41.040[DEBUG] Giving focus to GameCell 18:43:41.111[DEBUG] Cell #7 - added 18:43:41.139[DEBUG] Cell #2 - destroyed 18:43:41.723[DEBUG] Giving focus to GameCell 18:43:41.792[DEBUG] Cell #8 - added 18:43:41.822[DEBUG] Cell #3 - destroyed 18:43:42.257[DEBUG] Giving focus to GameCell 18:43:42.325[DEBUG] Cell #9 - added 18:43:42.355[DEBUG] Cell #4 - destroyed 18:43:43.073[DEBUG] Requesting: https://gamebanana.com/apiv11/Util/Game/NameMatch?_sName=DRAGON%20BALL%20FighterZ 18:43:43.267[DEBUG] Requesting: https://gamebanana.com/apiv11/Game/6246/Subfeed?_nPage=1?_nPerpage=50&_csvModelInclusions=Mod 18:43:43.429[DEBUG] Downloading image: https://images.gamebanana.com/img/banners/games/6270052034aa6.jpg 18:43:43.535[DEBUG] 15 mods found 18:43:43.538[DEBUG] Cell #0 - added 18:43:43.541[DEBUG] Mod name : Copy Vegeta 18:43:43.542[DEBUG] Cell #1 - added 18:43:43.544[DEBUG] Mod name : Magician's Red 18:43:43.545[DEBUG] Cell #2 - added 18:43:43.547[DEBUG] Mod name : Orlando Perfect Cell 18:43:43.547[DEBUG] Cell #3 - added 18:43:43.550[DEBUG] Mod name : Sonic Adventure Music Pack 18:43:43.550[DEBUG] Cell #4 - added 18:43:43.552[DEBUG] Mod name : DazzArts SSJ4 Gogeta Recolor 18:43:43.553[DEBUG] Cell #5 - added 18:43:43.555[DEBUG] Mod name : Thank You Toriyama. 18:43:43.556[DEBUG] Cell #6 - added 18:43:43.556[DEBUG] Giving focus to ModCell 18:43:44.206[DEBUG] Giving focus to ModCell 18:43:44.873[DEBUG] Giving focus to ModCell 18:43:45.173[DEBUG] Giving focus to ModCell 18:43:45.205[DEBUG] Cell #0 - destroyed 18:43:45.308[DEBUG] Mod name : Smooth Cell 18:43:45.309[DEBUG] Cell #7 - added 18:43:45.423[DEBUG] Giving focus to ModCell 18:43:45.455[DEBUG] Cell #1 - destroyed 18:43:45.555[DEBUG] Mod name : Ultimate Dragon Ball FighterZ Mod - Season 2 v2.01 18:43:45.556[DEBUG] Cell #8 - added 18:43:45.690[DEBUG] Giving focus to ModCell 18:43:45.722[DEBUG] Cell #2 - destroyed 18:43:45.822[DEBUG] Mod name : Frieza with 2 guns 18:43:45.823[DEBUG] Cell #9 - added 18:43:46.373[DEBUG] Giving focus to ModCell 18:43:46.405[DEBUG] Cell #3 - destroyed 18:43:46.505[DEBUG] Mod name : Kokonoe Labcoat 21 (Color 02-12) 18:43:46.506[DEBUG] Cell #10 - added 18:43:46.723[DEBUG] Giving focus to ModCell 18:43:46.755[DEBUG] Cell #4 - destroyed 18:43:46.855[DEBUG] Mod name : Original Gogeta on Color03-04 wo shader 18:43:46.856[DEBUG] Cell #11 - added 18:43:46.973[DEBUG] Giving focus to ModCell 18:43:47.005[DEBUG] Cell #5 - destroyed 18:43:47.073[DEBUG] Giving focus to ModCell 18:43:47.089[DEBUG] Mod name : Goku from Fortnite 18:43:47.089[DEBUG] Cell #12 - added 18:43:47.122[DEBUG] Cell #6 - destroyed 18:43:47.173[DEBUG] Giving focus to ModCell 18:43:47.189[DEBUG] Mod name : Infinite Azure 18:43:47.189[DEBUG] Cell #13 - added 18:43:47.239[DEBUG] Cell #7 - destroyed 18:43:47.290[DEBUG] Giving focus to ModCell 18:43:47.305[DEBUG] Mod name : Majin Janemba (Dragon Ball Heroes) 18:43:47.306[DEBUG] Cell #14 - added 18:43:47.339[DEBUG] Cell #8 - destroyed 18:43:47.439[DEBUG] Mod name : BLM Beast Gohan 18:43:47.439[DEBUG] Cell #15 - added 18:43:47.623[DEBUG] Giving focus to ModCell 18:43:47.655[DEBUG] Cell #9 - destroyed 18:43:47.873[DEBUG] Giving focus to ModCell 18:43:47.990[DEBUG] Giving focus to ModCell 18:43:50.323[DEBUG] Search button pressed 18:43:57.986[DEBUG] Requesting: https://gamebanana.com/apiv11/Game/6246/Subfeed?_nPage=1&_nPerpage=50&_sName=nude&_csvModelInclusions=Mod 18:43:58.198[DEBUG] Cell #0 - added 18:43:58.198[DEBUG] Mod name : Nude Android 21 (Lab Coat) 18:43:58.198[DEBUG] Cell #1 - added 18:43:58.198[DEBUG] Mod name : Nude Videl Edits 18:43:58.199[DEBUG] Cell #2 - added 18:43:58.199[DEBUG] Mod name : Nude Android 21 (Majin) 18:43:58.199[DEBUG] Cell #3 - added 18:43:58.229[INFO] AppletFocusState_InFocus 18:43:59.856[DEBUG] Giving focus to ModCell 18:44:00.656[DEBUG] Giving focus to ModCell 18:44:01.790[DEBUG] Giving focus to ModCell 18:44:02.390[DEBUG] Giving focus to ModCell 18:44:03.890[DEBUG] Giving focus to ModCell 18:44:04.256[DEBUG] Giving focus to ModCell 18:44:04.723[DEBUG] Giving focus to ModCell 18:44:05.056[DEBUG] Giving focus to ModCell 18:44:05.873[DEBUG] Mod name : Nude Android 21 (Lab Coat) 18:44:05.873[DEBUG] Requesting: https://gamebanana.com/apiv11/Mod/487651?_csvProperties=_sText,_aFiles,_aPreviewMedia 18:44:06.012[DEBUG] Giving focus to brls::ScrollingFrame (id="mod_preview_scrolling") 18:44:06.089[DEBUG] Giving focus to brls::Button (id="download") 18:44:06.090[DEBUG] Downloading image: https://images.gamebanana.com/img/ss/mods/65923b5f490ea.jpg 18:44:06.105[DEBUG] Giving focus to brls::ScrollingFrame (id="mod_preview_scrolling") 18:44:06.221[DEBUG] Downloading image: https://images.gamebanana.com/img/ss/mods/65923b6208b1e.jpg 18:44:06.376[DEBUG] Download

To Reproduce Steps to reproduce the behavior:

  1. Go to any mod with alot of high quality images
  2. Click on the mod in the list for a game with a large mod fanbase.
  3. See error

Expected behavior Page loads perfectly and you can download the mods inside

Screenshots If applicable, add screenshots to help explain your problem.

Switch:

Additional context It’s literally only on the 2.0.0 version of this and it wont download mods properly if its not the latest one

DeathNorn commented 3 months ago

Also it does it on the dragon ball z fighters section of mods alot for example the pic below “excuse the broken screen protector”. image image

PoloNX commented 3 months ago

does it do the same thing for all games ?

PoloNX commented 3 months ago

Maybe it's a problem with ssl certificate. your console time is synced ? you can sync it with https://github.com/nedex/QuickNTP

PoloNX commented 3 months ago

I can see what you searched with your logs ( ͡° ͜ʖ ͡° )

DeathNorn commented 3 months ago

Yah dont worry about the searches ahaha ill sync the certificate

DeathNorn commented 3 months ago

Your app is very usefull for an otherwise annoying modding scene for setup

DeathNorn commented 3 months ago

Also what server should it be synced to

DeathNorn commented 3 months ago

Also i synced it with main and it crashes less but some mods when loaded do crashes still

DeathNorn commented 3 months ago

Maybe im missing something else

FlameSlap commented 3 months ago

I'm having the same exact issue. Nothing downloads. Everything crashes. My time is synced as well.

Edit: I resynced it with QuickNTP cloudflare and it loads the mod now but the download button doesnt click. In other words it wont even initiate the download.

FlameSlap commented 3 months ago

Also i synced it with main and it crashes less but some mods when loaded do crashes still

Are you able to click the download button?

PoloNX commented 3 months ago

Also i synced it with main and it crashes less but some mods when loaded do crashes still

Which mod ? Hour should be sync to improve the security with ssl certificates. Without them, someone can edit informations you receive.

PoloNX commented 3 months ago

I'm having the same exact issue. Nothing downloads. Everything crashes. My time is synced as well.

Edit: I resynced it with QuickNTP cloudflare and it loads the mod now but the download button doesnt click. In other words it wont even initiate the download.

It's because the mod doesn't contain romfs folder so is incompatible with the app

FlameSlap commented 3 months ago

I'm having the same exact issue. Nothing downloads. Everything crashes. My time is synced as well.

Edit: I resynced it with QuickNTP cloudflare and it loads the mod now but the download button doesnt click. In other words it wont even initiate the download.

It's because the mod doesn't contain romfs folder so is incompatible with the app

image

The download button in your app does not work for any mod. The one in the picture.

Edit: I think I understand what you mean about romfs now. I am trying to download SSBU fighters.

PoloNX commented 3 months ago

I made a fix for ssbu. Download the latest version in the Actions tab of the github

FlameSlap commented 3 months ago

I made a fix for ssbu. Download the latest version in the Actions tab of the github

I don't understand how to get a precompiled copy from here.

image

image

I don't have a work environment to compile it in.

PoloNX commented 3 months ago

My bad I didn't upload assets in the workflow. I'm not on my computer so I can't edit it. I'll send you a build soon

PoloNX commented 3 months ago

Juste edited from my phone. You should find a build here when it's finished https://github.com/PoloNX/SimpleModDownloader/actions/runs/8471358046

FlameSlap commented 3 months ago

Juste edited from my phone. You should find a build here when it's finished https://github.com/PoloNX/SimpleModDownloader/actions/runs/8471358046

Got it testing now. 👍🏻

Edit: We are on a roll! Working with SSBU now! 👏🏻🙌🏻🤙🏻✌🏻🤝🏼😁😃

image

FlameSlap commented 3 months ago

Dang... after the mod downloaded and I backed out of the app by pressing the B button it crashed. I think the mod downloaded fine though. Let me have a look and see.

image

Edit: I tried it again with a second SSBU mod and the same thing happened. After I download the mod and back out with B, it crashes.

Edit 2: bartman and el chavo mods both downloaded and installed fine though.

image

DeathNorn commented 3 months ago

Wow i didn’t expect such a great action taken im taken aback by the creators supportiveness for his users. Ill be keeping and eye out for this guy and also telling everyone about how great he is.

DeathNorn commented 3 months ago

Edit it crashes more now sadly

DeathNorn commented 3 months ago

Basically unusable

DeathNorn commented 3 months ago

Tried it on minecraft mods as well

FlameSlap commented 3 months ago

Tried it on minecraft mods as well

You need to give more detail if you want to try and see if the developer can fix it. Pictures help too sometimes.

PoloNX commented 3 months ago

Dang... after the mod downloaded and I backed out of the app by pressing the B button it crashed. I think the mod downloaded fine though. Let me have a look and see.

image

Edit: I tried it again with a second SSBU mod and the same thing happened. After I download the mod and back out with B, it crashes.

Edit 2: bartman and el chavo mods both downloaded and installed fine though.

image

Fixed one bug and a new one appear, this week end I'll have some times to fix everything

PoloNX commented 3 months ago

Hey @FlameSlap @DeathNorn I fixed a lot of bugs. The error when you press "B" was introduced in a new commit of borealis which was a breaking change and I completly forgot about it. Can you try the last build here ? Normally there's a message when a mod isn't supported or when you search a mod with a string lower than 3 characters https://github.com/PoloNX/SimpleModDownloader/actions/runs/8489971503

PoloNX commented 3 months ago

Now it's not necessary to sync the time

PoloNX commented 3 months ago

https://github.com/PoloNX/SimpleModDownloader/assets/57038157/e9db5b95-66c2-44f7-af0a-9bfc501eb461

FlameSlap commented 3 months ago

https://github.com/PoloNX/SimpleModDownloader/assets/57038157/e9db5b95-66c2-44f7-af0a-9bfc501eb461

Is this updated version already in the release tab?

Edit: Why does the artifact for simplemoddownloader say UpcomingSwitchGames?

PoloNX commented 3 months ago

Lmao copy past moment

PoloNX commented 3 months ago

Fixed

FlameSlap commented 3 months ago

Fixed

Just a side note. The latest upcomingswitchgames artifact still crashes/freezes after backing out pressing the B button.

image

PoloNX commented 3 months ago

You're talking of SimpleModDownloader or UpcomingSwitchGames ?

FlameSlap commented 3 months ago

You're talking of SimpleModDownloader or UpcomingSwitchGames ?

This error is from Upcomingswitchgames because that is what the artifact had before you fixed it. I tested it and Just wanted to let you know.

PoloNX commented 3 months ago

Oh okay. I know this issue I should fix it

FlameSlap commented 3 months ago

Oh okay. I know this issue I should fix it

I tested simplemodmanager now and it ran smoothly! 👏🏻🤙🏻🙌🏻 No crashes or freezes and I was able to back out with no problems so far. I was also able to download a mod with zero issues. 👍🏻

FlameSlap commented 3 months ago

Basically unusable

You need to have patience young grasshoppa, He is working very hard on his apps and they are working much MUCH better now. 🙌🏻👏🏻👍🏻🤜🏻🤛🏻

PoloNX commented 3 months ago

Ahah thanks. Can I close the issue or you have another thing to notice ?

FlameSlap commented 3 months ago

Ahah thanks. Can I close the issue or you have another thing to notice ?

I think it's fine to close it now. The app is downloading mods just fine that are compatible and it is no longer crashing.